Hlint use elem and use notElem#11135
Merged
Merged
Conversation
Bodigrim
approved these changes
Aug 6, 2025
geekosaur
approved these changes
Aug 6, 2025
mergify
Bot
added
the
ready and waiting
philderbeast
force-pushed
the
hlint/elem-notElem
branch
2 times, most recently
from
6c0298f to
fd39581
Compare
ulysses4ever
approved these changes
Aug 7, 2025
Collaborator
|
I personally find hlint suggestions annoying and would rather not have to do the busy-work to satisfy the linter. Therefore I would rather we kept most of the suggestions disabled. |
Collaborator
Author
|
I've learnt a lot over the years from hlint suggestions (thanks hlint). I find satisfying the linter to be a low effort change in almost all cases and I'm happy to do that work. |
- Bump hlint counts
philderbeast
force-pushed
the
hlint/elem-notElem
branch
from
612f934 to
6221bb7
Compare
mergify
Bot
added
the
merge delay passed
86 tasks
2 tasks
Collaborator
|
@mpickering thank you for sharing your perspective. I'll add it to the meeting agenda, 'cause I don't see an easy resolution here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #9110. After #11093 merged, I started on suggestions with a two count so that these warnings are no longer ignored and will be picked up by our CI linting.
The "Use elem" suggestion with a 2-count I feel is better paired with the "Use notElem" suggestion (with a 9-count) rather than the other 2-count suggestions.
Each applied suggestion is an individual commit but I'll squash these if this pull request is approved.