Satisfy HLint suggestions for isDigit and isAscii#11126
Merged
Conversation
ffaf1
approved these changes
Aug 4, 2025
59c21b3 to
7a04eb7
Compare
andreasabel
approved these changes
Aug 4, 2025
geekosaur
approved these changes
Aug 4, 2025
- Follow hlint suggestion: Use isDigit - Follow hlint suggestion: Use isAsciiLower - Follow hlint suggestion: Use isAsciiUpper
7a04eb7 to
9260dac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #9110. After #11093 merged, I started on suggestions with a two count so that these warnings are no longer ignored and will be picked up by our CI linting.
I stopped short of doing all of these as the suggested is digit and is ASCII changes lead me to another change to reuse
isAsciiAlphaand because I'm unsure about when and why base functions should be added tomodule Distribution.Compat.Prelude.cabal/Cabal-syntax/src/Distribution/Compat/Prelude.hs
Lines 6 to 11 in 9b26df8
cabal/Cabal-syntax/src/Distribution/Compat/Prelude.hs
Lines 137 to 140 in 9b26df8
I also removed
isNum, usingisDigitinstead inmodule Distribution.Client.VCS.Each applied suggestion is an individual commit but I'll squash these if this pull request is approved.