Client: Handle grpc-status #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any non OK grpc status is stringified to not make a breaking API change. Ideally this would not be the case the status can be useful for the application. This commit also reverts the assumption that presence of grpc-message implies an error. This is not according to the specification and even the server in this repository sometimes sets grpc-message on OK. This didn't cause any issues because the grpc-message was being lookup in the HTTP headers, while according to the spec it must always be set in the trailers.
10 tasks
pcapriotti
added a commit
to wireapp/wire-server
that referenced
this pull request
Sep 24, 2021
We now depend on a fork of http2-grpc-haskell containing fixes for: haskell-grpc-native/http2-grpc-haskell#46 haskell-grpc-native/http2-grpc-haskell#48 as well as the master of http2-client: https://github.com/lucasdicioccio/http2-client
4 tasks
pcapriotti
added a commit
to wireapp/wire-server
that referenced
this pull request
Sep 28, 2021
* Merge http2 grpc fixes We now depend on a fork of http2-grpc-haskell containing fixes for: haskell-grpc-native/http2-grpc-haskell#46 haskell-grpc-native/http2-grpc-haskell#48 as well as the master of http2-client: https://github.com/lucasdicioccio/http2-client * Clarify comment about http2-client fixes Co-authored-by: jschaul <jschaul@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any non OK grpc status is stringified to not make a breaking API change. Ideally
this would not be the case as the status can be useful for the application.
This commit also reverts the assumption that presence of grpc-message implies an
error. This is not according to the specification and even the server in this
repository sometimes sets grpc-message on OK. This didn't cause any issues
because the grpc-message was being lookup in the HTTP headers, while according
to the spec it must always be set in the trailers.
Partially fixes #6