Fix getNotifications#511
Merged
andreasabel merged 2 commits intohaskell-github:masterfrom May 9, 2025
Merged
Conversation
This goes against the documentation at https://docs.github.com/en/rest/activity/notifications but it seems to be required in order to handle certain types of notifications.
maralorn
commented
Sep 24, 2024
| | AssignReason | ||
| | AuthorReason | ||
| | CommentReason | ||
| | CiActivityReason |
Contributor
Author
There was a problem hiding this comment.
Note that I am not 100% if this is the correct capitalisation, but CIActivity looked fishy. ;-)
Contributor
Author
|
CI error looks unrelated. |
Member
|
Nice, thanks! If you rebase on Can you please a test or an example use of the new API features? (See the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #510 and #504. (I simply included the commit by @magthe.)