Fast and correct aeson instances for UTCTime#45
Open
ondrap wants to merge 4 commits intohaskell-github-trust:masterfrom
Open
Fast and correct aeson instances for UTCTime#45ondrap wants to merge 4 commits intohaskell-github-trust:masterfrom
ondrap wants to merge 4 commits intohaskell-github-trust:masterfrom
Conversation
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch does several things:
UTCTimeencode and parse vs. Time instancesUTCTime: they used to be ~ twice slower than time, now it is ~2 times faster. I basically copied the encoding instance from aeson and I have written the parsing myself.decode (encode time)) == Just timefor time between 1AC-9999AC).ZonedTimeinstance as it seemed to me it parsed more formats than I would expect (the RFC3339) - if you feel I should change that, send me a note and I could do that.scannerpackage; the parser is about twice as fast as an identicalattoparsecparser, I think it makes senseBenchmark results: