Merged
Conversation
Member
brandonchinn178
approved these changes
Jan 25, 2024
Member
brandonchinn178
left a comment
brandonchinn178
left a comment
There was a problem hiding this comment.
yeah, that should work
Member
Author
|
@brandonchinn178 wrote: Cabal head jobs are failing in CI atm, so something is not working. |
Member
|
It seems to work for me! https://github.com/brandonchinn178/aeson-schemas/blob/main/.github%2Fworkflows%2Fghc-compat-test.yml |
Member
Author
Yes, that is what I meant: your implementation works. |
Member
Member
Author
|
I merged this into main too quickly. Reopened in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@brandonchinn178 : Is the change (replacing
node16bynode20) sufficient to switch to node 20? No change on the dependencies needed?Along with this bump, I think we should bump the action to v3 and release the outstanding PRs:
enable-matcher; implyenable-stack#6What do you think?