Skip to content

When clicking on the cracked hashes in chunk it should link to cracks… #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
correct-horse-battery-bench wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

When clicking on the cracked hashes in chunk it should link to cracks… #697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/core/_components/tables/base-table/base-table.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,10 @@ describe('BaseTableComponent', () => {
});

it('should render cracked link from chunk', (done) => {
const mockChunk = { taskId: 1, cracked: 100 } as JChunk;
const mockChunk = { id: 1, taskId: 2, cracked: 100 } as JChunk;
component.renderCrackedLinkFromChunk(mockChunk).subscribe((links) => {
expect(links.length).toBe(1);
expect(links[0].routerLink).toEqual(['/hashlists', 'hashes', 'tasks', 1]);
expect(links[0].routerLink).toEqual(['/hashlists', 'hashes', 'chunks', 1]);
expect(links[0].label).toBe('100');
done();
});
Expand Down
2 changes: 1 addition & 1 deletion src/app/core/_components/tables/base-table/base-table.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ export class BaseTableComponent {
const links: HTTableRouterLink[] = [];
if (chunk) {
links.push({
routerLink: ['/hashlists', 'hashes', 'tasks', chunk.taskId],
routerLink: ['/hashlists', 'hashes', 'chunks', chunk.id],
label: chunk.cracked.toLocaleString()
});
}
Expand Down
4 changes: 2 additions & 2 deletions src/app/core/_components/tables/chunks-table/chunks-table.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,11 +295,11 @@ describe('ChunksTableComponent', () => {
it('should render CRACKED column routerLink with correct path and label', (done) => {
const columns = component.getColumns();
const crackedColumn = columns.find((col) => col.id === ChunksTableCol.CRACKED);
const chunk = { taskId: 5, cracked: 100 } as JChunk;
const chunk = { id: 9, taskId: 5, cracked: 100 } as JChunk;

crackedColumn?.routerLink!(chunk).subscribe((links) => {
expect(links.length).toBe(1);
expect(links[0].routerLink).toEqual(['/hashlists', 'hashes', 'tasks', 5]);
expect(links[0].routerLink).toEqual(['/hashlists', 'hashes', 'chunks', 9]);
expect(links[0].label).toBe('100');
done();
});
Expand Down
Loading