2141 enhancement no errors when creating hashlist with missing data#692
Open
correct-horse-battery-bench wants to merge 3 commits into
Open
Conversation
The previous selector required `.mat-form-field-touched`, which is not a real Material class, so it never matched and the error border silently disappeared. Match invalidity via the `.field-stack.is-invalid` wrapper (custom CVA inputs) and Material's own `.mat-form-field-invalid` (direct formControlName fields), and add the `--destructive-ring` token in light/dark themes.
The error border was restored previously, but the subscript wrapper that holds Material's error text stayed hidden, so the message never appeared. Display `.mat-mdc-form-field-subscript-wrapper` when the field-stack is `.is-invalid` so the validation message shows alongside the red border. Also scope `ht-table-editable` layout to `:has(.editable-container)` and drop the stray `.mat-icon` offsets so the message label aligns correctly inside editable table cells.
github-project-automation
Bot
moved this to Todo
in 🥂 JUNE - Bugs & Enhancements - Last Milestones for 1.0
correct-horse-battery-bench
moved this from Todo
to In Progress
in 🥂 JUNE - Bugs & Enhancements - Last Milestones for 1.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added missing design tokens in light css and do not hide the validation error below the field.
Issue: hashtopolis/server#2141