2130 always place sort arrow to the left of column labels#689
Open
correct-horse-battery-bench wants to merge 1 commit into
Open
2130 always place sort arrow to the left of column labels#689correct-horse-battery-bench wants to merge 1 commit into
correct-horse-battery-bench wants to merge 1 commit into
Conversation
The mat-sort-header arrowPosition was conditional on isNumeric
('before' for numeric columns, 'after' otherwise), so sort arrows
appeared inconsistently to the left or right of column labels.
Pin arrowPosition to 'before' so the sort button is always rendered
to the left of every column label across all tables.
github-project-automation
Bot
moved this to Todo
in 🥂 JUNE - Bugs & Enhancements - Last Milestones for 1.0
correct-horse-battery-bench
moved this from Todo
to Review
in 🥂 JUNE - Bugs & Enhancements - Last Milestones for 1.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin arrow button to the left of the table column label.
Issue: hashtopolis/server#2130