Fix feature=alloc build #90
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Spencer <matthew@thespencers.me.uk>
Signed-off-by: Matt Spencer <matthew@thespencers.me.uk>
Author
|
Hi Guys I was trying to use this crate with a rp2040 project I am working on. I noticed that it was failing with "--no-default-features --features=alloc". I believe this PR fixes the problem. Should I also add configuration to the test running to build the 'alloc' feature version of the crate? |
Author
|
Thanks for enabling the actions to be run. |
Author
|
Interestingly, for me, master branch is failing in the same way on my local machine |
Assuming that master branch was working before, I have updated the configuration to ignore new clippy warnings. Signed-off-by: Matt Spencer <matthew@thespencers.me.uk>
Author
|
I have updated the clippy configuration to ignore the new linting falures (apart from the double quoted single char which I have fixed). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.