Skip to content

H-6116: Extract PopoverPanel and PopoverMenuItem components#8352

Draft
kube wants to merge 1 commit intographite-base/8352from
cf/h-6116-playback-components-cleanup-animation
Draft

H-6116: Extract PopoverPanel and PopoverMenuItem components#8352
kube wants to merge 1 commit intographite-base/8352from
cf/h-6116-playback-components-cleanup-animation

Conversation

@kube
Copy link
Collaborator

@kube kube commented Feb 3, 2026

🌟 What is the purpose of this PR?

🔗 Related links

  • ...

🚫 Blocked by

  • ...

🔍 What does this change?

  • ...

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing
  • modifies an npm-publishable library and I have added a changeset file(s)
  • modifies a Cargo-publishable library and I have amended the version
  • modifies a Cargo-publishable library, but it is not yet ready to publish
  • modifies a block that will need publishing via GitHub action once merged
  • I am unsure / need advice

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change
  • are in a state where docs changes are not yet required but will be
  • require changes to docs which are made as part of this PR
  • require changes to docs which are not made in this PR
    • Provide more detail here
  • I am unsure / need advice

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph
  • affected the execution graph, and the turbo.json's have been updated to reflect this
  • I am unsure / need advice

⚠️ Known issues

🐾 Next steps

🛡 What tests cover this?

❓ How to test this?

  1. Checkout the branch / view the deployment
  2. Try X
  3. Confirm that Y

📹 Demo

@kube @claude
H-6116: Extract PopoverPanel and PopoverMenuItem components
27b5592 
Add reusable popover components for settings popovers:
- PopoverPanel: container with title and close button
- PopoverSection: grouped section with optional title
- PopoverMenuItem: selectable menu item with icon and checkmark

Refactor SimulationControls to use the new components, reducing
code duplication and improving maintainability.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions github-actions bot added area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team labels Feb 3, 2026
This was referenced Feb 3, 2026
Merged
Merged
@kube Graphite App
Copy link
Collaborator Author

kube commented Feb 3, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kube kube mentioned this pull request Feb 3, 2026
Open
3 tasks
@vercel
Copy link

vercel bot commented Feb 3, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview, Comment Feb 3, 2026 4:22pm
petrinaut Ready Ready Preview, Comment Feb 3, 2026 4:22pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
hashdotdesign Ignored Ignored Feb 3, 2026 4:22pm
hashdotdesign-tokens Ignored Ignored Feb 3, 2026 4:22pm

@kube kube changed the base branch from cf/h-5770-simulation-computeplayback to graphite-base/8352 February 3, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kube kube

Labels

area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kube