fix: fix audit FIND-075#1231
Open
mamoralesiob wants to merge 1 commit into
Open
Conversation
| * @param exponent The value to validate before use as a power-of-ten exponent. | ||
| */ | ||
| function checkExponentOverflow(uint256 exponent) internal pure { | ||
| if (exponent >= MAX_DECIMALS) { |
Contributor
Author
There was a problem hiding this comment.
In the same DecimalsLib.sol library the checkExponentOverflow function is defined in.
mamoralesiob
force-pushed
the
fix/find-075
branch
from
e9e2a04 to
55401da
Compare
marcosio
requested changes
Jun 1, 2026
| * @param exponent The value to validate before use as a power-of-ten exponent. | ||
| */ | ||
| function checkExponentOverflow(uint256 exponent) internal pure { | ||
| if (exponent >= MAX_DECIMALS) { |
Contributor
There was a problem hiding this comment.
Is cheaper > than >=. Can we go by this way?
Signed-off-by: mamoralesiob <miguelangel@io.builders>
mamoralesiob
force-pushed
the
fix/find-075
branch
from
55401da to
7867913
Compare
marcosio
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
https://iobuilders.atlassian.net/browse/BBND-1792
Type of change
Testing
Node version:
Checklist