Skip to content

refactor: move some facets from layer_2 to facets directory#1225

Open
mamoralesiob wants to merge 2 commits into
developmentfrom
feat/move_kpi_fixedRate_amortization
Open

refactor: move some facets from layer_2 to facets directory#1225
mamoralesiob wants to merge 2 commits into
developmentfrom
feat/move_kpi_fixedRate_amortization

Conversation

@mamoralesiob
Copy link
Copy Markdown
Contributor

Description

The following facets were moved from facets/layer_2 to facets directory:

  • Amortization
  • FixedRate
  • Kpi
  • KpiLinkedRate

Type of change

  • Bug fix 🐞
  • New feature ✨
  • Breaking change 💥
  • Documentation update 📖
  • Refactor 🔧

Testing

Node version:

  • 20
  • 22
  • 24

Checklist

  • Style Guidelines followed ✅
  • Documentation Updated 📚
  • Linters - No New Warnings ⚠️
  • Local Tests Pass ✅
  • Effective Tests Added ✔️
  • No reduction of Coverage

Signed-off-by: mamoralesiob <miguelangel@io.builders>
@mamoralesiob mamoralesiob self-assigned this Jun 1, 2026
@mamoralesiob mamoralesiob requested review from a team as code owners June 1, 2026 11:39
@mamoralesiob mamoralesiob requested a review from pathornteng June 1, 2026 11:39
@github-actions github-actions Bot added the hash-change PR modifies @custom:hash annotations or codegen formula — review on-chain impact carefully label Jun 1, 2026
Signed-off-by: mamoralesiob <miguelangel@io.builders>
import { IStaticFunctionSelectors } from "../../infrastructure/proxy/IStaticFunctionSelectors.sol";

contract AmortizationFacet is Amortization, IStaticFunctionSelectors {
function getStaticResolverKey() external pure override returns (bytes32 staticResolverKey_) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NatSpec

/// @custom:hash resolverKey KpiLinkedRate
bytes32 constant RESOLVER_KEY_KPI_LINKED_RATE = 0x47cd76ae576f0ec85f1abfc652d614750caefe22a465bef2c859f6cb32a89593;

interface IKpiLinkedRate {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

natspec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hash-change PR modifies @custom:hash annotations or codegen formula — review on-chain impact carefully

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants