Skip to content

feat: create a new asset deposit token new configuration and deploy deposit token#1223

Merged
themariofrancia merged 12 commits into
developmentfrom
BBND-1804-create-a-new-asset-deposit-token-new-configuration-and-deploy-deposit-token
Jun 1, 2026
Merged

feat: create a new asset deposit token new configuration and deploy deposit token#1223
themariofrancia merged 12 commits into
developmentfrom
BBND-1804-create-a-new-asset-deposit-token-new-configuration-and-deploy-deposit-token

Conversation

@themariofrancia
Copy link
Copy Markdown
Contributor

Description

Type of change

  • Bug fix 🐞
  • New feature ✨
  • Breaking change 💥
  • Documentation update 📖
  • Refactor 🔧

Testing

Node version:

  • 20
  • 22
  • 24

Checklist

  • Style Guidelines followed ✅
  • Documentation Updated 📚
  • Linters - No New Warnings ⚠️
  • Local Tests Pass ✅
  • Effective Tests Added ✔️
  • No reduction of Coverage

Signed-off-by: Mario Francia <mariofranciarius@gmail.com>
…te-a-new-asset-deposit-token-new-configuration-and-deploy-deposit-token

# Conflicts:
#	packages/ats/contracts/contracts/factory/ERC3643/interfaces/IFactory.sol
#	packages/ats/contracts/contracts/factory/Factory.sol
#	packages/ats/contracts/contracts/factory/IFactory.sol
#	packages/ats/contracts/scripts/domain/factory/types.ts

Signed-off-by: Mario Francia <mariofranciarius@gmail.com>
…BND-1804-create-a-new-asset-deposit-token-new-configuration-and-deploy-deposit-token

# Conflicts:
#	packages/ats/contracts/contracts/factory/ERC3643/interfaces/IFactory.sol
#	packages/ats/contracts/contracts/factory/IFactory.sol

Signed-off-by: Mario Francia <mariofranciarius@gmail.com>
Signed-off-by: Mario Francia <mariofranciarius@gmail.com>
@themariofrancia themariofrancia requested review from a team as code owners June 1, 2026 09:38
@themariofrancia themariofrancia self-assigned this Jun 1, 2026
@themariofrancia themariofrancia added the New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. label Jun 1, 2026
Signed-off-by: Mario Francia <mariofranciarius@gmail.com>
Signed-off-by: Mario Francia <mariofranciarius@gmail.com>
Signed-off-by: Mario Francia <mariofranciarius@gmail.com>
Copy link
Copy Markdown
Contributor

@marcosio marcosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments to have clearer naming and code structure.

Comment thread packages/ats/contracts/contracts/factory/Factory.sol Outdated
Comment thread packages/ats/contracts/contracts/factory/Factory.sol
Comment thread packages/ats/contracts/contracts/factory/Factory.sol
Comment thread packages/ats/contracts/contracts/factory/Factory.sol
Signed-off-by: Mario Francia <mariofranciarius@gmail.com>
Comment thread packages/ats/contracts/contracts/factory/Factory.sol
Signed-off-by: Mario Francia <mariofranciarius@gmail.com>
Signed-off-by: Mario Francia <mariofranciarius@gmail.com>
Signed-off-by: Mario Francia <mariofranciarius@gmail.com>
Signed-off-by: Mario Francia <mariofranciarius@gmail.com>
@themariofrancia themariofrancia merged commit beab0e9 into development Jun 1, 2026
14 of 16 checks passed
@themariofrancia themariofrancia deleted the BBND-1804-create-a-new-asset-deposit-token-new-configuration-and-deploy-deposit-token branch June 1, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Feature A new feature, service, or documentation. Major changes that are not backwards compatible.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants