refactor(contracts): EVM accessor pattern — compile-time test-override generator (BBND-1672)

[MiguelLZPF]

Description

Replaces the runtime TimeTravel storage-wrapper time-control pattern with a compile-time, manifest-driven EvmAccessors generator.

Production mode — native-opcode getters (block.timestamp, block.number) with zero test machinery compiled in.
Test mode — slot-fallback getters plus override writers exposed via a test-only EvmAccessorsFacet, injected into the diamond at deploy time.

Key integration points:

• buildFacetList now sources isTestMode() (from the merged facetEnvironment — PR refactor: facetEnvironment to control facets in tests/productions env… #1210) and conditionally appends EvmAccessorsFacet.
• Centralised initializer (feat: initializers #1161) wires the facet without changes to the init order.
• The useTimeTravel parameter is removed from all create*Configuration signatures and every deploy workflow / CLI entry point. This is a breaking deploy-script API change, fully documented in the changeset.

Jira: BBND-1672

How it works

One source API — EvmAccessors.getX() — compiled into two different bodies chosen at compile time by isTestMode(). Production gets the bare opcode (zero overhead); tests get an override slot with a sentinel fallback, driven by a test-only facet.

  ┌──────────────────────────────────────────────────────────────────┐
  │  manifest.ts  ·  ONE line per native value (the source of truth)  │
  │     block.timestamp · block.number · msg.sender · block.chainid   │
  └───────────────────────────────┬──────────────────────────────────┘
                                  │  generator.ts reads it at compile time
                   isTestMode()?  │  (ATS_TEST_MODE env / the hardhat task)
              ┌───────────────────┴────────────────────┐
          NO (production)                          YES (tests)
              │                                         │
              ▼                                         ▼
  ┌──────────────────────────┐      ┌───────────────────────────────────────┐
  │ EvmAccessors.sol (PROD)  │      │ EvmAccessors.sol (TEST)               │
  │ getBlockTimestamp() {    │      │ getBlockTimestamp() {                 │
  │   return block.timestamp │      │   v = overrideSlot.timestamp          │
  │ }                        │      │   return v==0 ? block.timestamp : v   │  sentinel
  │ -> just the opcode:      │      │ }                                     │  fallback
  │    no slot, no SLOAD,    │      │ + setTimestampOverride(...)  (writer)  │
  │    no test code. 0 gas.  │      │ + ERC-7201 override storage slot      │
  └──────────────────────────┘      └──────────────────┬────────────────────┘
              │                                         │ writers poked by
   CI gate (accessors:check:prod)                      v
   fails the build if any override    ┌───────────────────────────────────────┐
   machinery leaks into PROD          │ EvmAccessorsFacet (test-only facet)   │
                                      │   changeSystemTimestamp / Sender /     │
                                      │   ChainId / Blocknumber  (+ resets)    │
                                      └───────────────────────────────────────┘

Example — time-travel with no real time passing (the P1.1 guard test):

  test -> facet.changeSystemTimestamp(2030)  writes the override slot
       -> LockFacet.release() reads EvmAccessors.getBlockTimestamp() -> 2030
       -> the lock counts as expired, release succeeds

Why it beats the old pattern: TimeTravelStorageWrapper baked an SLOAD + branch into every native read in both prod and test — production paid a tax for a tests-only feature. Moving the decision to compile time gives prod the bare opcode (smaller bytecode, no override slot to attack) from a single manifest line.

Type of change

• Bug fix 🐞
• New feature ✨
• Breaking change 💥
• Documentation update 📖
• Refactor 🔧

Testing

Full contract suite run locally against Hardhat:

• npm run ats:contracts:build — green (TypeChain + registry regenerated)
• npm run ats:contracts:format — green (no drift)
• npm run ats:contracts:lint — green (no new warnings)
• npm run ats:contracts:test — 3701 passing, 5 pending, 0 failing

Test Results (if any)

3701 passing · 5 pending · 0 failing

Node version:

• 20
• 22
• 24

Checklist

• Style Guidelines followed ✅
• Documentation Updated 📚
• Linters - No New Warnings ⚠️
• Local Tests Pass ✅
• Effective Tests Added ✔️
• No reduction of Coverage ✅