test(contracts): add upgradeMockFacet1AnyVersion and remove untested_…#1221
Draft
marcosio wants to merge 1 commit into
Draft
test(contracts): add upgradeMockFacet1AnyVersion and remove untested_…#1221marcosio wants to merge 1 commit into
marcosio wants to merge 1 commit into
Conversation
…initializers - add upgradeMockFacet1AnyVersion() to IMockFacet1 interface and MockFacet1 contract; uses onlyFacetRegistered with an empty _fromLastVersions array to exercise the if (length == 0) return early-exit branch in checkFacetRegistered - register upgradeMockFacet1AnyVersion selector in getStaticFunctionSelectors - delete untested_initializers.test.ts; all 10 initializer methods it covered already have full 3-case tests (AccountHasNoRole, happy path, FacetAlreadyRegistered) in their respective facet test files Signed-off-by: Marcos Serradilla Diez <marcos@io.builders>
marcosio
requested review from
AlbertoMolinaIoBuilders,
MiguelLZPF and
mamoralesiob
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…initializers
Description
Type of change
Testing
Node version:
Checklist