Skip to content

feat: remove bond and equity facets#1204

Open
Axel-IoBuilders wants to merge 6 commits into
developmentfrom
feat/BBND-1713-SC
Open

feat: remove bond and equity facets#1204
Axel-IoBuilders wants to merge 6 commits into
developmentfrom
feat/BBND-1713-SC

Conversation

@Axel-IoBuilders
Copy link
Copy Markdown
Contributor

Description

Type of change

  • Bug fix 🐞
  • New feature ✨
  • Breaking change 💥
  • Documentation update 📖
  • Refactor 🔧

Testing

Node version:

  • 20
  • 22
  • 24

Checklist

  • Style Guidelines followed ✅
  • Documentation Updated 📚
  • Linters - No New Warnings ⚠️
  • Local Tests Pass ✅
  • Effective Tests Added ✔️
  • No reduction of Coverage

@Axel-IoBuilders Axel-IoBuilders self-assigned this May 26, 2026
@Axel-IoBuilders Axel-IoBuilders requested review from a team as code owners May 26, 2026 13:26
@Axel-IoBuilders Axel-IoBuilders requested a review from Neurone May 26, 2026 13:26
@github-actions github-actions Bot added the hash-change PR modifies @custom:hash annotations or codegen formula — review on-chain impact carefully label May 26, 2026
Copy link
Copy Markdown
Contributor

@marcosio marcosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We made a regression test deploying the environment in some place?

@Axel-IoBuilders Axel-IoBuilders force-pushed the feat/BBND-1713-SC branch 4 times, most recently from 1e7ab3b to 61bfad3 Compare May 28, 2026 14:29
Signed-off-by: Axel-IoBuilders <108282711+Axel-IoBuilders@users.noreply.github.com>
Signed-off-by: Axel-IoBuilders <108282711+Axel-IoBuilders@users.noreply.github.com>
Signed-off-by: Axel-IoBuilders <108282711+Axel-IoBuilders@users.noreply.github.com>
Signed-off-by: Axel-IoBuilders <108282711+Axel-IoBuilders@users.noreply.github.com>
Signed-off-by: Axel-IoBuilders <108282711+Axel-IoBuilders@users.noreply.github.com>
Signed-off-by: Axel-IoBuilders <108282711+Axel-IoBuilders@users.noreply.github.com>
(, , data, isDisabled_) = CorporateActionsStorageWrapper.getCorporateAction(corporateActionId_);

_checkUnexpectedError(data.length == 0, BALANCE_ADJ_DATA);
(balanceAdjustment_) = abi.decode(data, (IScheduledBalanceAdjustment.ScheduledBalanceAdjustment));
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed ().


_checkUnexpectedError(data.length == 0, BALANCE_ADJ_DATA);
(balanceAdjustment_) = abi.decode(data, (IScheduledBalanceAdjustment.ScheduledBalanceAdjustment));
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the correct place?

Comment thread packages/ats/contracts/contracts/facets/maturity/Maturity.sol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hash-change PR modifies @custom:hash annotations or codegen formula — review on-chain impact carefully

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants