fix: audit issue 117#1154
Merged
AlbertoMolinaIoBuilders merged 13 commits intoJun 1, 2026
Merged
Conversation
Signed-off-by: Alberto Molina <alberto@io.builders>
Signed-off-by: Alberto Molina <alberto@io.builders>
themariofrancia
approved these changes
May 19, 2026
themariofrancia
requested changes
May 19, 2026
| bool forceUpdate | ||
| ) internal { | ||
| if (!forceUpdate) | ||
| _checkUnexpectedError(coupon.rateStatus == ICouponTypes.RateCalculationStatus.SET, UPDATE_COUPON_RATE); |
Contributor
There was a problem hiding this comment.
show we add a test to validate it?
…D-1773-FIND-117 Signed-off-by: Alberto Molina <alberto@io.builders>
Signed-off-by: Alberto Molina <alberto@io.builders>
Signed-off-by: Alberto Molina <alberto@io.builders>
marcosio
requested changes
May 20, 2026
Signed-off-by: Alberto Molina <alberto@io.builders>
Signed-off-by: Alberto Molina <alberto@io.builders>
…D-1773-FIND-117 Signed-off-by: Alberto Molina <alberto@io.builders>
Signed-off-by: Alberto Molina <alberto@io.builders>
github-actions
Bot
added
the
hash-change
Signed-off-by: Alberto Molina <alberto@io.builders>
MiguelLZPF
removed
the
hash-change
…D-1773-FIND-117 Signed-off-by: Alberto Molina <alberto@io.builders>
marcosio
requested changes
May 25, 2026
Signed-off-by: Alberto Molina <alberto@io.builders>
…D-1773-FIND-117 Signed-off-by: Alberto Molina <alberto@io.builders>
marcosio
requested changes
Jun 1, 2026
Contributor
marcosio
left a comment
marcosio
left a comment
There was a problem hiding this comment.
Just a bytecode and gas reduction!
marcosio
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Testing
Node version:
Checklist