Skip to content

Add icon for ejentum-mcp#147

Open
ejentum wants to merge 2 commits into
hashgraph-online:mainfrom
ejentum:add-ejentum-icon
Open

Add icon for ejentum-mcp#147
ejentum wants to merge 2 commits into
hashgraph-online:mainfrom
ejentum:add-ejentum-icon

Conversation

@ejentum
Copy link
Copy Markdown
Contributor

@ejentum ejentum commented May 22, 2026

Adds the `icon` field for the `ejentum-mcp` entry, requested in ejentum/ejentum-mcp#1.

Changes:

  • `plugins.json`: add `"icon": "./plugins/ejentum/ejentum-mcp/assets/ejentum-icon.svg"` to the `ejentum-mcp` entry
  • `plugins/ejentum/ejentum-mcp/assets/ejentum-icon.svg`: the icon file (square SVG, brand mark)

Same icon used by the published `n8n-nodes-ejentum` node, so the mark stays consistent across the Codex and n8n marketplace surfaces.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds an icon to the ejentum-mcp plugin configuration and introduces the corresponding SVG asset. A review comment identifies an opportunity to optimize the new SVG file by removing numerous empty path elements that increase file size without contributing to the visual output.

Comment on lines +43 to +202
<path d="" fill="#E2132A" transform="translate(0,0)"/>
<path d="" fill="#E3162D" transform="translate(0,0)"/>
<path d="" fill="#DE162C" transform="translate(0,0)"/>
<path d="" fill="#E4122B" transform="translate(0,0)"/>
<path d="" fill="#E3162A" transform="translate(0,0)"/>
<path d="" fill="#E3132C" transform="translate(0,0)"/>
<path d="" fill="#E4162C" transform="translate(0,0)"/>
<path d="" fill="#E5132C" transform="translate(0,0)"/>
<path d="" fill="#E1142D" transform="translate(0,0)"/>
<path d="" fill="#E4142B" transform="translate(0,0)"/>
<path d="" fill="#E1172D" transform="translate(0,0)"/>
<path d="" fill="#E7132B" transform="translate(0,0)"/>
<path d="" fill="#E2152D" transform="translate(0,0)"/>
<path d="" fill="#E41429" transform="translate(0,0)"/>
<path d="" fill="#E2152C" transform="translate(0,0)"/>
<path d="" fill="#DE192D" transform="translate(0,0)"/>
<path d="" fill="#DF142B" transform="translate(0,0)"/>
<path d="" fill="#E4162C" transform="translate(0,0)"/>
<path d="" fill="#E1162D" transform="translate(0,0)"/>
<path d="" fill="#E0142A" transform="translate(0,0)"/>
<path d="" fill="#E1152A" transform="translate(0,0)"/>
<path d="" fill="#E7142A" transform="translate(0,0)"/>
<path d="" fill="#E4152B" transform="translate(0,0)"/>
<path d="" fill="#DF182B" transform="translate(0,0)"/>
<path d="" fill="#E0162B" transform="translate(0,0)"/>
<path d="" fill="#DE1128" transform="translate(0,0)"/>
<path d="" fill="#DF142C" transform="translate(0,0)"/>
<path d="" fill="#D71B2C" transform="translate(0,0)"/>
<path d="" fill="#D9182B" transform="translate(0,0)"/>
<path d="" fill="#DA1A2C" transform="translate(0,0)"/>
<path d="" fill="#D51A2B" transform="translate(0,0)"/>
<path d="" fill="#D71929" transform="translate(0,0)"/>
<path d="" fill="#DE132B" transform="translate(0,0)"/>
<path d="" fill="#DD142C" transform="translate(0,0)"/>
<path d="" fill="#DD162A" transform="translate(0,0)"/>
<path d="" fill="#DF142C" transform="translate(0,0)"/>
<path d="" fill="#DE162D" transform="translate(0,0)"/>
<path d="" fill="#DD172C" transform="translate(0,0)"/>
<path d="" fill="#E0132C" transform="translate(0,0)"/>
<path d="" fill="#E1122A" transform="translate(0,0)"/>
<path d="" fill="#DC182B" transform="translate(0,0)"/>
<path d="" fill="#DD162A" transform="translate(0,0)"/>
<path d="" fill="#DB142B" transform="translate(0,0)"/>
<path d="" fill="#DD1528" transform="translate(0,0)"/>
<path d="" fill="#D71428" transform="translate(0,0)"/>
<path d="" fill="#D7152D" transform="translate(0,0)"/>
<path d="" fill="#DE152B" transform="translate(0,0)"/>
<path d="" fill="#DF1429" transform="translate(0,0)"/>
<path d="" fill="#D5172A" transform="translate(0,0)"/>
<path d="" fill="#D8172A" transform="translate(0,0)"/>
<path d="" fill="#DF132A" transform="translate(0,0)"/>
<path d="" fill="#DE152D" transform="translate(0,0)"/>
<path d="" fill="#DF1329" transform="translate(0,0)"/>
<path d="" fill="#E0142D" transform="translate(0,0)"/>
<path d="" fill="#E1152C" transform="translate(0,0)"/>
<path d="" fill="#DC172E" transform="translate(0,0)"/>
<path d="" fill="#DF152C" transform="translate(0,0)"/>
<path d="" fill="#D8152C" transform="translate(0,0)"/>
<path d="" fill="#E1142A" transform="translate(0,0)"/>
<path d="" fill="#DA152B" transform="translate(0,0)"/>
<path d="" fill="#DF172D" transform="translate(0,0)"/>
<path d="" fill="#E2152A" transform="translate(0,0)"/>
<path d="" fill="#DC132A" transform="translate(0,0)"/>
<path d="" fill="#E4162C" transform="translate(0,0)"/>
<path d="" fill="#D9182C" transform="translate(0,0)"/>
<path d="" fill="#E2182C" transform="translate(0,0)"/>
<path d="" fill="#E3182F" transform="translate(0,0)"/>
<path d="" fill="#DD132D" transform="translate(0,0)"/>
<path d="" fill="#E3132C" transform="translate(0,0)"/>
<path d="" fill="#E0162D" transform="translate(0,0)"/>
<path d="" fill="#E2162D" transform="translate(0,0)"/>
<path d="" fill="#E4172D" transform="translate(0,0)"/>
<path d="" fill="#E2112A" transform="translate(0,0)"/>
<path d="" fill="#E6162D" transform="translate(0,0)"/>
<path d="" fill="#E11329" transform="translate(0,0)"/>
<path d="" fill="#E1152B" transform="translate(0,0)"/>
<path d="" fill="#DB162B" transform="translate(0,0)"/>
<path d="" fill="#DB1A2E" transform="translate(0,0)"/>
<path d="" fill="#DC192D" transform="translate(0,0)"/>
<path d="" fill="#E0152C" transform="translate(0,0)"/>
<path d="" fill="#E3162E" transform="translate(0,0)"/>
<path d="" fill="#E2182D" transform="translate(0,0)"/>
<path d="" fill="#DE182E" transform="translate(0,0)"/>
<path d="" fill="#DC152A" transform="translate(0,0)"/>
<path d="" fill="#E2172C" transform="translate(0,0)"/>
<path d="" fill="#DF152C" transform="translate(0,0)"/>
<path d="" fill="#DA132B" transform="translate(0,0)"/>
<path d="" fill="#DF172D" transform="translate(0,0)"/>
<path d="" fill="#DA162D" transform="translate(0,0)"/>
<path d="" fill="#DA162B" transform="translate(0,0)"/>
<path d="" fill="#DC1730" transform="translate(0,0)"/>
<path d="" fill="#DB162C" transform="translate(0,0)"/>
<path d="" fill="#D8142B" transform="translate(0,0)"/>
<path d="" fill="#D71A31" transform="translate(0,0)"/>
<path d="" fill="#DB1A30" transform="translate(0,0)"/>
<path d="" fill="#D8152B" transform="translate(0,0)"/>
<path d="" fill="#DE162B" transform="translate(0,0)"/>
<path d="" fill="#E0162D" transform="translate(0,0)"/>
<path d="" fill="#D9132C" transform="translate(0,0)"/>
<path d="" fill="#DA132B" transform="translate(0,0)"/>
<path d="" fill="#D91A2E" transform="translate(0,0)"/>
<path d="" fill="#D9132B" transform="translate(0,0)"/>
<path d="" fill="#D7162B" transform="translate(0,0)"/>
<path d="" fill="#DE172E" transform="translate(0,0)"/>
<path d="" fill="#D81C30" transform="translate(0,0)"/>
<path d="" fill="#D8152B" transform="translate(0,0)"/>
<path d="" fill="#DB1529" transform="translate(0,0)"/>
<path d="" fill="#DA1B2E" transform="translate(0,0)"/>
<path d="" fill="#D8152D" transform="translate(0,0)"/>
<path d="" fill="#DC182E" transform="translate(0,0)"/>
<path d="" fill="#DB172B" transform="translate(0,0)"/>
<path d="" fill="#DA172D" transform="translate(0,0)"/>
<path d="" fill="#DB162D" transform="translate(0,0)"/>
<path d="" fill="#DA172C" transform="translate(0,0)"/>
<path d="" fill="#DC142E" transform="translate(0,0)"/>
<path d="" fill="#DA1A2F" transform="translate(0,0)"/>
<path d="" fill="#DC192D" transform="translate(0,0)"/>
<path d="" fill="#DE182D" transform="translate(0,0)"/>
<path d="" fill="#DE172C" transform="translate(0,0)"/>
<path d="" fill="#DB162C" transform="translate(0,0)"/>
<path d="" fill="#D9162A" transform="translate(0,0)"/>
<path d="" fill="#DD162C" transform="translate(0,0)"/>
<path d="" fill="#DE152D" transform="translate(0,0)"/>
<path d="" fill="#DB162A" transform="translate(0,0)"/>
<path d="" fill="#DC162B" transform="translate(0,0)"/>
<path d="" fill="#DB172C" transform="translate(0,0)"/>
<path d="" fill="#DB182C" transform="translate(0,0)"/>
<path d="" fill="#DE162E" transform="translate(0,0)"/>
<path d="" fill="#E0172C" transform="translate(0,0)"/>
<path d="" fill="#DF162D" transform="translate(0,0)"/>
<path d="" fill="#DB192C" transform="translate(0,0)"/>
<path d="" fill="#DC152B" transform="translate(0,0)"/>
<path d="" fill="#DD182D" transform="translate(0,0)"/>
<path d="" fill="#DB162C" transform="translate(0,0)"/>
<path d="" fill="#DA1C30" transform="translate(0,0)"/>
<path d="" fill="#DA1D2F" transform="translate(0,0)"/>
<path d="" fill="#DE172B" transform="translate(0,0)"/>
<path d="" fill="#E0172D" transform="translate(0,0)"/>
<path d="" fill="#DE182E" transform="translate(0,0)"/>
<path d="" fill="#DE142A" transform="translate(0,0)"/>
<path d="" fill="#DE182E" transform="translate(0,0)"/>
<path d="" fill="#DD1D2E" transform="translate(0,0)"/>
<path d="" fill="#DF162A" transform="translate(0,0)"/>
<path d="" fill="#DE152B" transform="translate(0,0)"/>
<path d="" fill="#E1162E" transform="translate(0,0)"/>
<path d="" fill="#DB1A2D" transform="translate(0,0)"/>
<path d="" fill="#DE162C" transform="translate(0,0)"/>
<path d="" fill="#D9182B" transform="translate(0,0)"/>
<path d="" fill="#E0172C" transform="translate(0,0)"/>
<path d="" fill="#DB1C2D" transform="translate(0,0)"/>
<path d="" fill="#DF192E" transform="translate(0,0)"/>
<path d="" fill="#DD182D" transform="translate(0,0)"/>
<path d="" fill="#E3182C" transform="translate(0,0)"/>
<path d="" fill="#E3152C" transform="translate(0,0)"/>
<path d="" fill="#E3162C" transform="translate(0,0)"/>
<path d="" fill="#E2172C" transform="translate(0,0)"/>
<path d="" fill="#E0152D" transform="translate(0,0)"/>
<path d="" fill="#E3172F" transform="translate(0,0)"/>
<path d="" fill="#E2162B" transform="translate(0,0)"/>
<path d="" fill="#E4172E" transform="translate(0,0)"/>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The SVG file contains a large number of empty <path> elements (lines 43-202, as well as several others like lines 20-21, 29, 31-37, and 40) that do not render any content. These redundant elements significantly increase the file size without providing any visual benefit. Removing them will optimize the asset and improve maintainability.

@kilo-code-bot
Copy link
Copy Markdown

kilo-code-bot Bot commented May 22, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)
  • plugins.json — icon field added for ejentum-mcp plugin
  • plugins/ejentum/ejentum-mcp/.codex-plugin/plugin.json — composerIcon field added
  • plugins/ejentum/ejentum-mcp/assets/ejentum-icon.svg — new SVG asset added

Reviewed by step-3.5-flash · 284,049 tokens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant