Skip to content

Conversation

@ihcsim
Copy link
Contributor

@ihcsim ihcsim commented Jan 19, 2026

Problem:

Follow-up on #260 (comment) - update FOSSA scan workflow to watch the correct release branches.

Signed-off-by: Ivan Sim <1330522+ihcsim@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 19, 2026 20:52
@ihcsim ihcsim requested review from a team, Vicente-Cheng, Yu-Jack and tserong as code owners January 19, 2026 20:52
@ihcsim ihcsim self-assigned this Jan 19, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the FOSSA scanning workflow to use a more specific branch pattern for release branches, changing from release/** to v[0-9]+.[0-9]+ to match version-based branch names.

Changes:

  • Modified the branch trigger pattern in the FOSSA workflow from release/** to v[0-9]+.[0-9]+ to align with the repository's release branch naming convention

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

on:
push:
branches: ["main", "master", "release/**"]
branches: ["main", "master", "v[0-9]+.[0-9]+"]
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch pattern v[0-9]+.[0-9]+ is incorrect for GitHub Actions workflow triggers. In glob patterns, the dot (.) is interpreted literally as any single character, not just a period. This means the pattern would incorrectly match branch names like v1X2 in addition to v1.2.

For consistency with other workflows in this repository (basic-ci.yaml and scan.yml), the pattern should be 'v**' to match all version branches starting with 'v'. Alternatively, if you need to match only semantic version patterns, you should use v[0-9]+.[0-9]+* to allow for patch versions like v1.2.3.

Suggested change
branches: ["main", "master", "v[0-9]+.[0-9]+"]
branches: ["main", "master", "v**"]

Copilot uses AI. Check for mistakes.
@ihcsim ihcsim merged commit 1df9415 into master Jan 19, 2026
14 checks passed
@ihcsim ihcsim deleted the ihcsim-patch-1 branch January 19, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants