updating the ssh_authorized_keys to sshAuthorizedKeys

[clemenko]

updating the ssh_authorized_keys to sshAuthorizedKeys

Problem:

Solution:

Related Issue(s):

Test plan:

Additional documentation or context

[brandond]

Just comparing what's here in the docs to the actual struct in the code... I think a bunch of the fields are wrong :/ If you're up for a full audit.

Ref: https://github.com/harvester/harvester-installer/blob/39cbe00063b3764bf98844dd556ab4f4a20f1548/pkg/config/config.go#L204-L222

The fields are also really inconsistent about whether they should be mixedCaseLikeThis or allinlowercase or lowercase_with_underscores.

[clemenko]

updated from https://github.com/harvester/harvester-installer/blob/39cbe00063b3764bf98844dd556ab4f4a20f1548/pkg/config/config.go#L204-L222

[wheatdog]

We have a little discussion on the internal slack channel. We think the original key form, like ssh_authorized_keys, is valid given this implementation: https://github.com/harvester/harvester-installer/blob/39cbe00063b3764bf98844dd556ab4f4a20f1548/pkg/config/rename.go#L25-L30 (Thank @starbops for pointing out this code snippet!)

cc @jillian-maroket

[clemenko]

We have a little discussion on the internal slack channel. We think the original key form, like ssh_authorized_keys, is valid given this implementation: https://github.com/harvester/harvester-installer/blob/39cbe00063b3764bf98844dd556ab4f4a20f1548/pkg/config/rename.go#L25-L30 (Thank @starbops for pointing out this code snippet!)

cc @jillian-maroket

I can confirm ssh_authorized_keys does not work. And sshAuthorizedKeys does. Have you personally tested it? Is there a unit test for it?

[wheatdog]

@clemenko Yes, we do have unit tests. See

• https://github.com/harvester/harvester-installer/blob/0474823a712851d74bda6f573e892a0eb7c13423/pkg/config/schemas_test.go#L18-L26
• https://github.com/harvester/harvester-installer/blob/0474823a712851d74bda6f573e892a0eb7c13423/pkg/config/testdata/harvester-config.yaml#L5-L7

Would you mind sharing your config and the test steps? Thanks!

[clemenko]

Let me run another test. I may have had a double entry in the yaml.
Side note is it would be nice to have some consistency in the variable names.