Skip to content

Fix bug segfault/other memory bugs when concatenating string literals and list literals #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
a2435191 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix bug segfault/other memory bugs when concatenating string literals and list literals #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions harmony_model_checker/charm/ops.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2207,7 +2207,7 @@ void do_Load(struct state *state, struct step *step,
unsigned total = vip->size;
vip++;
for (unsigned int i = k; i < size; i++, vip++) {
if (VALUE_TYPE(indices[k]) != VALUE_ATOM) {
if (VALUE_TYPE(indices[i]) != VALUE_ATOM) {
char *p = value_string(av);
value_ctx_failure(step->ctx, step->allocator, "Load %s: bad string index", p);
free(p);
Expand Down Expand Up @@ -2253,7 +2253,7 @@ void do_Load(struct state *state, struct step *step,
unsigned total = vip->size;
vip++;
for (unsigned int i = k; i < size; i++, vip++) {
if (VALUE_TYPE(indices[k]) != VALUE_LIST) {
if (VALUE_TYPE(indices[i]) != VALUE_LIST) {
char *p = value_string(av);
value_ctx_failure(step->ctx, step->allocator, "Load %s: bad list index", p);
free(p);
Expand Down