Skip to content

Please consider the following formatting changes to #12514 #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alibuild wants to merge 1 commit into from
Closed

Please consider the following formatting changes to #12514 #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions PWGJE/Tasks/jetTaggerHFQA.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.

Check failure on line 1 in PWGJE/Tasks/jetTaggerHFQA.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-task] 

Specify task name only when it cannot be derived from the struct name. Only append to the default name.
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
Expand Down Expand Up @@ -446,14 +446,14 @@
template <typename T, typename U>
bool isAcceptedJet(U const& jet)
{
if (jetAreaFractionMin > -98.0) {

Check failure on line 449 in PWGJE/Tasks/jetTaggerHFQA.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
if (jet.area() < jetAreaFractionMin * o2::constants::math::PI * (jet.r() / 100.0) * (jet.r() / 100.0)) {
return false;
}
}
bool checkConstituentPt = true;
bool checkConstituentMinPt = (leadingConstituentPtMin > -98.0);

Check failure on line 455 in PWGJE/Tasks/jetTaggerHFQA.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
bool checkConstituentMaxPt = (leadingConstituentPtMax < 9998.0);

Check failure on line 456 in PWGJE/Tasks/jetTaggerHFQA.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
if (!checkConstituentMinPt && !checkConstituentMaxPt) {
checkConstituentPt = false;
}
Expand Down Expand Up @@ -612,7 +612,7 @@
if (fillIPxyz)
registry.fill(HIST("h2_jet_pt_sign_impact_parameter_xyz_significance_N2"), jet.pt(), vecSignImpXYZSig[1][0]);
}
if (vecSignImpXYSig.size() > 2) { // N3

Check failure on line 615 in PWGJE/Tasks/jetTaggerHFQA.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
if (fillIPxy)
registry.fill(HIST("h2_jet_pt_sign_impact_parameter_xy_significance_N3"), jet.pt(), vecSignImpXYSig[2][0]);
if (fillIPz)
Expand Down Expand Up @@ -766,7 +766,7 @@
if (fillIPxyz)
registry.fill(HIST("h3_jet_pt_sign_impact_parameter_xyz_significance_flavour_N2"), mcdjet.pt(), vecSignImpXYZSig[jetflavour][1], jetflavour, eventWeight);
}
if (vecImpXY[jetflavour].size() > 2) { // N3

Check failure on line 769 in PWGJE/Tasks/jetTaggerHFQA.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
if (fillIPxy)
registry.fill(HIST("h3_jet_pt_sign_impact_parameter_xy_significance_flavour_N3"), mcdjet.pt(), vecSignImpXYSig[jetflavour][2], jetflavour, eventWeight);
if (fillIPz)
Expand Down Expand Up @@ -1142,10 +1142,11 @@
}
int jetflavour = mcdjet.origin();
float secondaryPt = 0;
float totalJetPt = 0;
float totalJetPt = 0;
for (auto const& track : mcdjet.template tracks_as<JetTagTracksMCD>()) {
float varImpXY = track.dcaXY() * jettaggingutilities::cmTomum;
if (!track.has_mcParticle()) continue;
if (!track.has_mcParticle())
continue;
auto mcParticle = track.mcParticle();
totalJetPt += track.pt();
if (mcParticle.isPhysicalPrimary()) {
Expand Down Expand Up @@ -1633,5 +1634,5 @@
WorkflowSpec defineDataProcessing(ConfigContext const& cfgc)
{
return WorkflowSpec{
adaptAnalysisTask<JetTaggerhfQACharged>(cfgc, TaskName{"jet-taggerhf-qa-charged"})}; // o2-linter: disable=name/o2-task

Check failure on line 1637 in PWGJE/Tasks/jetTaggerHFQA.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-task] 

Device names jet-taggerhf-qa-charged and jet-taggerhf-q-a-charged generated from the specified task name jet-taggerhf-qa-charged and from the struct name JetTaggerhfQACharged, respectively, differ in hyphenation. Consider fixing capitalisation of the struct name to JetTaggerhfQaCharged and removing TaskName.
}
Loading