Generate path-redirect URLs instead of subdomain URLs#198
Conversation
Replace subdomain-based routing with port-based routing scheme. Registry URLs now use path redirects (e.g., /app-id/) instead of subdomain URLs. Routing YAML no longer includes subdomain or entry_points fields. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Review ResponseSummaryThe review had 9 findings. I accepted 5 (Critical 1, Critical 2, Major 5, Major 6, Minor 7), rejected 4 (Major 3, Major 4, Minor 8, Minor 9). All changes have been made and tests pass (61/61). Accepted
Rejected
All changes are squashed into the feature commit via |
336e1cf to
fe19641
Compare
Summary
https://{{domain}}/app-id/) for routed apps instead of subdomain URLssubdomainorentry_pointsfieldsMotivation
Companion to halos-org/halos-core-containers port-based routing migration. The build-time tooling must generate URLs matching the new routing scheme.
Related: halos-org/halos-mdns-publisher#37
Test plan
🤖 Generated with Claude Code