Merged
Conversation
Disable lots of tools and features that we don't need for Halide buildbots. On my Mac, this drops the install dir from ~6GB to ~2GB, and the compressed size from ~1.5GB to ~0.5GB.
alexreinking
approved these changes
Jan 25, 2024
alexreinking
requested changes
Jan 25, 2024
alexreinking
approved these changes
Jan 25, 2024
abadams
reviewed
Jan 25, 2024
|
|
||
|
|
||
| # options in LLVM that we always want OFF because they aren't needed | ||
| # for Halide buildbot usage. |
Member
There was a problem hiding this comment.
This comment is wrong and misleading. This doesn't just affect the LLVM used on the buildbots. This is also the LLVM that gets bundled into our libHalide binary releases. Not building the tools has no effect on that, but these decisions are decisions we're making for downstream users of libHalide, not just on our buildbots.
abadams
reviewed
Jan 25, 2024
| "CLANG_TOOL_SCAN_VIEW_BUILD" | ||
| "CLANG_TOOLS_EXTRA_INCLUDE_DOCS" | ||
| "LLVM_BUILD_UTILS" | ||
| "LLVM_ENABLE_BINDINGS" |
Member
There was a problem hiding this comment.
This looks like the same set of features of libLLVM that were disabled before the PR, so my beef is strictly with the comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable lots of tools and features that we don't need for Halide buildbots. On my Mac, this drops the install dir from ~6GB to ~2GB, and the compressed size from ~1.5GB to ~0.5GB.