Skip to content

Move Makefile testing to GitHub Actions#8929

Merged
alexreinking merged 9 commits intomainfrom
gha-make
Feb 2, 2026
Merged

Move Makefile testing to GitHub Actions#8929
alexreinking merged 9 commits intomainfrom
gha-make

Conversation

@alexreinking
Copy link
Member

@alexreinking alexreinking commented Feb 1, 2026

We only have four workflows left for Makefiles on the buildbots, so the complexity they add to the buildbot master configuration code is no longer justified. This PR aims to replace the buildbot testing for Make with GitHub Actions.

This is in service of a larger project of pinning the LLVM main version inside the repository.

Corresponding build_bot PR: halide/build_bot#315

@alexreinking alexreinking added the skip_buildbots Do not run buildbots on this PR. Must add before opening PR as we scan labels immediately. label Feb 1, 2026
@alexreinking
Copy link
Member Author

alexreinking commented Feb 1, 2026

LLVM's APT repo does not provide i386 binaries for Ubuntu (anymore?), so there's no straightforward way to test it. We can consider re-enabling make/x86-32 in the future when GHA takes over responsibility for building LLVM. On the other hand, we could add arm-64 relatively easily.

@alexreinking alexreinking requested a review from abadams February 2, 2026 01:44
@alexreinking
Copy link
Member Author

From offline discussion with @abadams, we're happy to skip testing the makefile build on x86-32-linux.

@mcourteaux
Copy link
Contributor

I just hope that the reporting when something fails will be as clear (or clearer) as it was with the buildbots.

@alexreinking
Copy link
Member Author

Should be no different for the Makefiles which always relayed raw stdout/stderr

@alexreinking alexreinking merged commit 59bcd4b into main Feb 2, 2026
3 checks passed
@alexreinking alexreinking deleted the gha-make branch February 2, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip_buildbots Do not run buildbots on this PR. Must add before opening PR as we scan labels immediately.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants