Convert some other local mutators and visitors to mutate_with and visit_with#8894
Open
alexreinking wants to merge 16 commits intomainfrom
Open
Convert some other local mutators and visitors to mutate_with and visit_with#8894alexreinking wants to merge 16 commits intomainfrom
alexreinking wants to merge 16 commits intomainfrom
Conversation
abadams
reviewed
Dec 8, 2025
abadams
reviewed
Dec 9, 2025
Member
|
There are some clang-tidy things to fix, but I believe the failures are unrelated. |
alexreinking
force-pushed
the
alexreinking/convert-visitors
branch
from
b8b5d14 to
2dea76a
Compare
alexreinking
force-pushed
the
alexreinking/convert-visitors
branch
from
60b6c8b to
0f767d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A concurrent complement to #8893
AddAtomicMutex.cpp is a little scary, actually.