feat(quality): trial CodeRabbit alongside critic

[hadamrd]

Summary

• Add .coderabbit.yaml scoped to src/forge_loop/** with tests/** excluded from CodeRabbit review.
• Keep reviews.profile: assertive, enable Ruff, and disable overlapping generic style/language lint tools so CodeRabbit focuses on correctness and security.
• Document reviewer roles in docs/CONTRIBUTING.md: manifesto-aware critic owns style/architecture/testing rules; CodeRabbit is the second-opinion correctness/security reviewer.
• Opened verdict tracking issue: CodeRabbit trial verdict review #191, targeted for the 4-week review window ending July 1, 2026.

CodeRabbit install handoff

I cannot install the GitHub App from this CLI session. Operator: install CodeRabbit for hadamrd/forge-loop only at https://github.com/apps/coderabbitai, keep it on the free OSS plan, then re-trigger CodeRabbit on this PR.

CodeRabbit dashboard URL for repo verification: https://app.coderabbit.ai/dashboard (filter/select hadamrd/forge-loop after install).

Acceptance criteria

• .coderabbit.yaml exists at repo root.
• Review path filters include src/forge_loop/** and exclude tests/**.
• Ruff remains enabled; overlapping style/language tools are disabled and path instructions suppress generic style comments.
• reviews.profile: assertive is set.
• docs/CONTRIBUTING.md has a Reviewers section and conflict-resolution rule.
• Tracking issue opened for trial verdict: CodeRabbit trial verdict review #191.
• CodeRabbit GitHub App installed on hadamrd/forge-loop under the free OSS plan.
• Manual smoke PRs run after installation.

Testing

• uv run python -c 'import yaml; yaml.safe_load(open(".coderabbit.yaml")); print("yaml: ok")'
• uv run python -c 'import yaml; data=yaml.safe_load(open(".coderabbit.yaml")); assert data["reviews"]["profile"] == "assertive"; assert "src/forge_loop/**" in data["reviews"]["path_filters"]; assert "!tests/**" in data["reviews"]["path_filters"]; assert data["reviews"]["tools"]["ruff"]["enabled"] is True; print("coderabbit config sanity: ok")'
• rg -n "CodeRabbit|manifesto-aware critic|Reviewers" docs/CONTRIBUTING.md
• uv run pre-commit run --files .coderabbit.yaml docs/CONTRIBUTING.md
• uv run pre-commit run --all-files fails on pre-existing repo-wide Ruff/Pyright issues unrelated to this config/docs PR; Ruff also attempted broad Python rewrites, which were restored before this PR.
• lumen: discovery skipped (mcp__lumen__semantic_search unavailable in this session)

Fixes #159

[hadamrd]

Operator handoff for #159: I cannot install the GitHub App from this CLI session. Please install CodeRabbit for \ only at https://github.com/apps/coderabbitai, keep it on the free OSS plan, then re-trigger CodeRabbit on this PR. Verify the repo is visible in the CodeRabbit dashboard at https://app.coderabbit.ai/dashboard by selecting/filtering .

[hadamrd]

Operator handoff for #159: I cannot install the GitHub App from this CLI session. Please install CodeRabbit for hadamrd/forge-loop only at https://github.com/apps/coderabbitai, keep it on the free OSS plan, then re-trigger CodeRabbit on this PR. Verify the repo is visible in the CodeRabbit dashboard at https://app.coderabbit.ai/dashboard by selecting/filtering hadamrd/forge-loop.

[hadamrd]

[sev2/product] NO-SCAFFOLD-THEATRE: this PR adds the CodeRabbit integration config while the downstream consumer is not wired up; the PR also leaves manual smoke PRs unrun, so the config is orphaned and unverified. Install/wire CodeRabbit for this repo and run the src/tests/style smoke checks, or keep the integration out of the default surface until it is live.

[hadamrd]

[sev2/product] NO-SCAFFOLD-THEATRE: this PR adds the CodeRabbit integration config while the downstream consumer is not wired up; the PR also leaves manual smoke PRs unrun, so the config is orphaned and unverified. Install/wire CodeRabbit for this repo and run the src/tests/style smoke checks, or keep the integration out of the default surface until it is live.

[hadamrd]

Critic findings:

• [sev1/product] Issue #159 requires the CodeRabbit GitHub App to be installed on hadamrd/forge-loop and visible in repo integrations, but the PR body explicitly marks that acceptance item incomplete and only leaves an operator handoff. Complete the app installation, link the live repo dashboard, and re-trigger before merge.

[hadamrd]

Closing this because the current CodeRabbit trial spec depends on external GitHub App installation plus manual smoke PRs. That leaves a PR waiting on operator action, which is not acceptable for ForgeLoop as a fully automated repo tool. If we revisit second-opinion review, it should be implemented as an automated, locally invokable reviewer/tool adapter with a deterministic skip/fail contract, not as a manual install handoff.