test(control): lock replay cursor on projection failure#189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remediates the Forge critic finding from #187.
Change
replay_projectiontest where a projection applies one event, raises on the next event, and the durable projection cursor remains at the original stored sequence.Verification
uv run --extra dev pytest tests/test_control_restart_replay.py::TestControlRestartReplayInvariants::test_projection_failure_does_not_advance_stored_cursor -quv run --extra dev pytest tests/test_control_restart_replay.py tests/test_eventlog_sqlite.py tests/test_boot_context.py tests/test_cli.py tests/test_cli_status_control_plane.py -q-> 47 passeduv run --extra dev ruff check tests/test_control_restart_replay.pyuv run --extra dev ruff format --check tests/test_control_restart_replay.pyuv run --extra dev mypy src/forge_loop/eventloguv run --extra dev pyright tests/test_control_restart_replay.py