fix(status): ignore terminal workers in stale fallback#185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- prevent
forge-loop status --jsonfrom resurrecting a worker from stalestate.json.dispatchedafter a terminal worker event has already been observed\n- add a regression for the stalestale_unconfirmedmonitor noise seen while dogfooding #165/#168\n\n## Verification\n-env -u VIRTUAL_ENV uv run --extra dev pytest tests/test_cli.py::test_status_json_reports_active_workers_from_events tests/test_cli.py::test_status_json_falls_back_to_dispatched_state_when_worker_events_missing tests/test_cli.py::test_status_json_does_not_resurrect_terminal_worker_from_dispatched_state -q-> 3 passed\n-env -u VIRTUAL_ENV uv run --extra dev pytest tests/test_cli.py -q-> 33 passed\n-env -u VIRTUAL_ENV uv run --extra dev ruff check src/forge_loop/cli_status_commands.py tests/test_cli.py-> passed\n-env -u VIRTUAL_ENV uv run --extra dev ruff format --check src/forge_loop/cli_status_commands.py tests/test_cli.py-> passed\n-env -u VIRTUAL_ENV uv run --extra dev mypy src/forge_loop/cli_status_commands.py-> passed\n-env -u VIRTUAL_ENV uv run --extra dev pyright src/forge_loop/cli_status_commands.py tests/test_cli.py-> 0 errors\n-env -u VIRTUAL_ENV uv run forge-loop status --json-> active_workers [] in dogfood checkout