Skip to content

HCK-13020: comment index statement if statement, table or all columns inactive #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlikRakhmonov merged 2 commits into from
Oct 13, 2025
Merged

HCK-13020: comment index statement if statement, table or all columns inactive #165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06b47ea
HCK-13020: comment index statement if statement, table or all columns…
AlikRakhmonov Oct 10, 2025
56b1800
Merge branch 'develop' into HCK-13020
AlikRakhmonov Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions forward_engineering/ddlProvider/ddlHelpers/indexHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,7 @@ const mapIndexKey = ({ name, sortOrder, nullsOrder, collation, opclass }) => {
return `${wrapInQuotes(name)}${collationStr}${opclassStr}${sortOrderStr}${nullsOrderStr}`;
};

const getIndexKeys = ({ columns = [], isParentActivated }) => {
const isAllColumnsDeactivated = checkAllKeysDeactivated(columns);

const getIndexKeys = ({ columns = [], isParentActivated, isAllColumnsDeactivated }) => {
return getColumnsList(columns, isAllColumnsDeactivated, isParentActivated, mapIndexKey);
};

Expand Down Expand Up @@ -114,9 +112,12 @@ const createIndex = (tableName, index, dbData, isParentActivated = true) => {
? index.columns
: _.map(index.columns, column => _.omit(column, 'sortOrder', 'nullsOrder'));

const isAllColumnsDeactivated = checkAllKeysDeactivated(indexColumns);

const keys = getIndexKeys({
columns: indexColumns,
isParentActivated,
isAllColumnsDeactivated,
});
const options = getIndexOptions(index, isParentActivated);

Expand All @@ -134,7 +135,7 @@ const createIndex = (tableName, index, dbData, isParentActivated = true) => {
tableName: getNamePrefixedWithSchemaName(tableName, index.schemaName),
}),
{
isActivated: index.isActivated,
isActivated: index.isActivated && isParentActivated && !isAllColumnsDeactivated,
},
);
};
Expand Down