Skip to content

HCK-10544: $collstats error AWS #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chulanovskyi-bs merged 3 commits into from
Mar 27, 2025
Merged

HCK-10544: $collstats error AWS #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2aad354
chore: improve connection info logging
chulanovskyi-bs Mar 27, 2025
6a62ee5
fix: handle unsupported pipeline of getting documents count on aws
chulanovskyi-bs Mar 27, 2025
d94d32d
chore: removed redundant nested promise
chulanovskyi-bs Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion forward_engineering/helpers/applyToInstanceHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const applyToInstanceHelper = {
try {
logger.clear();
log.info(getSystemInfo(connectionInfo.appVersion));
log.info(connectionInfo);
log.info(connectionInfo, 'connectionInfo');

await connectionHelper.connect(connectionInfo, sshService);
connectionHelper.close(sshService);
Expand Down
4 changes: 2 additions & 2 deletions reverse_engineering/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ module.exports = {
try {
logger.clear();
log.info(getSystemInfo(connectionInfo.appVersion));
log.info(connectionInfo);
log.info(connectionInfo, 'connectionInfo');

await connectionHelper.connect(connectionInfo, sshService);

Expand Down Expand Up @@ -58,7 +58,7 @@ module.exports = {

logger.clear();
log.info(getSystemInfo(connectionInfo.appVersion));
log.info(connectionInfo);
log.info(connectionInfo, 'connectionInfo');

const includeSystemCollection = connectionInfo.includeSystemCollection;
const connection = await connectionHelper.connect(connectionInfo, sshService);
Expand Down
4 changes: 2 additions & 2 deletions shared/logHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ const toTime = number => {

const createLogger = ({ title, logger, hiddenKeys }) => {
return {
info(message) {
logger.log('info', { message }, title, hiddenKeys);
info(message, infoTitle) {
logger.log('info', message, infoTitle || title, hiddenKeys);
},

progress(message, dbName = '', tableName = '') {
Expand Down
13 changes: 10 additions & 3 deletions shared/mongoDbClient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,17 +222,24 @@ const createConnection = ({ connection }) => {
});
};

const getCountByDirectCommand = ({ db, collectionName, scale = 1000000 }) =>
db.command({ collStats: collectionName, scale }).catch(err => Promise.reject(getError(err)));

const getCount = (dbName, collectionName) => {
return new Promise((resolve, reject) => {
const db = connection.db(dbName);
const collection = db.collection(collectionName);

collection.estimatedDocumentCount((err, count) => {
if (err) {
return reject(getError(err));
} else {
if (!err) {
return resolve(count);
}

if (err.message.includes('Unrecognized pipeline stage name: $collStats')) {
return getCountByDirectCommand({ db, collectionName }).then(resolve).catch(reject);
}

return reject(getError(err));
});
});
};
Expand Down