Skip to content

HCK-14476: Wrong alter table name command params #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chulanovskyi-bs merged 1 commit into from
Jan 28, 2026
Merged

HCK-14476: Wrong alter table name command params #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions forward_engineering/alterScript/alterScriptHelpers/entityHelpers/alterTableNameHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ const {
getSchemaOfAlterCollection,
getSchemaNameFromCollection,
getNamePrefixedWithSchemaName,
wrapInQuotes,
} = require('../../../utils/general');
const { assignTemplates } = require('../../../utils/assignTemplates');
const templates = require('../../../ddlProvider/templates');
Expand Down Expand Up @@ -40,10 +41,7 @@ const getRenameTableScriptDtos = collection => {
const isContainerActivated = isParentContainerActivated(collection);
const isCollectionActivated = isContainerActivated && isObjectInDeltaModelActivated(collection);

const script = alterTableName(
getNamePrefixedWithSchemaName({ name: oldName, schemaName }),
getNamePrefixedWithSchemaName({ name: newName, schemaName }),
);
const script = alterTableName(getNamePrefixedWithSchemaName({ name: oldName, schemaName }), wrapInQuotes(newName));

return [AlterScriptDto.getInstance([script], isCollectionActivated, false)];
};
Expand Down
2 changes: 1 addition & 1 deletion shared/Db2Client/src/main/java/org/db2/Db2Service.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public int applyScript(String script) throws SQLException {
}

private String removeComments(String script) {
return script.replaceAll("(?s)(?m)(?<=\\n)(?:/\\*.*?\\*/|--.*?$)(?=\\n)", "");
return script.replaceAll("(?s)(?m)(?:^|(?<=\\n))(?:/\\*.*?\\*/|--.*?)(?=\\n|$)", "");
}

private String[] splitStatements(String query) {
Expand Down
Binary file modified shared/addons/Db2Client.jar
View file
Open in desktop
Binary file not shown.