Skip to content

HCK-14317: [Delta model] error is thrown when on Db2 Alter Script tab opening for delta model with deleted entities #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chulanovskyi-bs merged 3 commits into from
Jan 15, 2026
Merged

HCK-14317: [Delta model] error is thrown when on Db2 Alter Script tab opening for delta model with deleted entities #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec168b1
HCK-14317: Fix typo
Nightlngale Jan 14, 2026
701be6a
HCK-14317: Add missing params
Nightlngale Jan 14, 2026
4aff02b
Same fix for dropUk
Nightlngale Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 21 additions & 13 deletions forward_engineering/alterScript/alterScriptHelpers/alterForeignKeyHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,19 +25,27 @@ const getAddSingleForeignKeyStatementDto = relationship => {
const relationshipName = getRelationshipName(relationship);
const ddlProvider = require('../../ddlProvider/ddlProvider')();

return ddlProvider.createForeignKey({
name: relationshipName,
foreignKey: compMod.child.collection.fkFields,
primaryKey: compMod.parent.collection.fkFields,
customProperties: compMod.customProperties?.new,
foreignTable: compMod.child.collection.name,
foreignSchemaName: compMod.child.bucket.name,
foreignTableActivated: compMod.child.collection.isActivated,
primaryTable: compMod.parent.collection.name,
primarySchemaName: compMod.parent.bucket.name,
primaryTableActivated: compMod.parent.collection.isActivated,
isActivated: Boolean(relationship.role?.compMod?.isActivated?.new),
});
const schemaData = {
schemaName: compMod.child.bucket.name,
};

return ddlProvider.createForeignKey(
{
name: relationshipName,
foreignKey: compMod.child.collection.fkFields,
primaryKey: compMod.parent.collection.fkFields,
customProperties: compMod.customProperties?.new,
foreignTable: compMod.child.collection.name,
foreignSchemaName: compMod.child.bucket.name,
foreignTableActivated: compMod.child.collection.isActivated,
primaryTable: compMod.parent.collection.name,
primarySchemaName: compMod.parent.bucket.name,
primaryTableActivated: compMod.parent.collection.isActivated,
isActivated: Boolean(relationship.role?.compMod?.isActivated?.new),
},
{},
schemaData,
);
};

const canRelationshipBeAdded = relationship => {
Expand Down
14 changes: 10 additions & 4 deletions forward_engineering/ddlProvider/ddlHelpers/key/constraintsHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,11 @@ const alterPkConstraint = (tableName, isParentActivated, keyData) => {
};

const dropPK = tableName => {
const templatesConfig = { tableName };
return assignTemplates(templates.dropPK, templatesConfig);
const templateData = { tableName };
return assignTemplates({
templates: templates.dropPK,
templateData,
});
};

const alterUkConstraint = (tableName, isParentActivated, keyData) => {
Expand All @@ -69,11 +72,14 @@ const alterUkConstraint = (tableName, isParentActivated, keyData) => {
* @param constraintName {string}
* */
const dropUkConstraint = (tableName, constraintName) => {
const templatesConfig = {
const templateData = {
tableName,
constraintName,
};
return assignTemplates(templates.dropUkConstraint, templatesConfig);
return assignTemplates({
template: templates.dropUkConstraint,
templateData,
});
};

module.exports = {
Expand Down