Skip to content

As the modal is not dynamic at all we are force to rollback to a more usable state #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bigorn0 merged 1 commit into from
Jun 30, 2025
Merged

As the modal is not dynamic at all we are force to rollback to a more usable state #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions reverse_engineering/connection_settings_modal/connectionSettingsModalConfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,21 +19,7 @@
"inputKeyword": "projectId",
"inputType": "text",
"inputTooltip": "Project ID on Google Cloud Platform",
"dependency": {
"key": "authType",
"value": "app_default_credentials"
}
},
{
"inputLabel": "Project ID",
"inputKeyword": "optionalProjectId",
"inputType": "text",
"inputPlaceholder": "Optional",
"inputTooltip": "Project ID on Google Cloud Platform",
"dependency": {
"key": "authType",
"value": "service_account_key"
}
"inputPlaceholder": "Optional if using service account"
},
{
"inputLabel": "Dataset name",
Expand Down
2 changes: 1 addition & 1 deletion reverse_engineering/helpers/connectionHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ function getAuthInfo({ authType, connectionInfo }) {
}
// service account case and backward compatible value
return {
projectId: connectionInfo?.optionalProjectId,
projectId: connectionInfo.projectId,
credentialsFilePath: connectionInfo.keyFilename,
};
}
Expand Down
Loading