Fix build of plugin to allow its usage in the browser #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chulanovskyi-bs
approved these changes
May 29, 2025
chulanovskyi-bs
approved these changes
May 29, 2025
|
Vitalii4as
added a commit
that referenced
this pull request
May 30, 2025
This reverts commit 0a3784e.
Vitalii4as
added a commit
that referenced
this pull request
May 30, 2025
Vitalii4as
pushed a commit
that referenced
this pull request
Jun 2, 2025
Vitalii4as
added a commit
that referenced
this pull request
Jun 4, 2025
* Revert "Revert "Revert "Revert "Revert "Revert "HCK-10923: allow reverse-engineering …" (#87)" This reverts commit ef85ec4. * Revert "Revert "Revert "Revert "Revert "Revert "Fix build (#74)" (#76)" (#79)" (#81)"…" (#86)" This reverts commit 98829f6. * Reapply "Fix build of plugin to allow its usage in the browser (#80)" (#85) This reverts commit 6d15563. --------- Co-authored-by: hackolade-bot <hackolade-bot@hackolade.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical details
There were few issues:
http-proxy-agent,https-proxy-agent,fs-extrahave to be kept innode_modulesBig.js, It just didn't have proper prototype in the browser. When I moved it tonode_modulesit started to work.debugshould be kept in modules because it is bundled as for node, and the part for browser is ignored.node-fetchis replaced by our lib, it caused circular dependency. See more here fix circular dep when building the plugin in browser #75