HCK-10923: allow reverse-engineering in the browser #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitaliiBedletskyi
approved these changes
May 27, 2025
thomas-jakemeyn
approved these changes
May 27, 2025
added 2 commits
May 27, 2025 18:11
|
Vitalii4as
added a commit
that referenced
this pull request
May 29, 2025
This reverts commit 83d331e.
Vitalii4as
added a commit
that referenced
this pull request
May 29, 2025
Vitalii4as
added a commit
that referenced
this pull request
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
Add support for RE in the browser.
Technical details
client.requestit returns content with metadata, so I had to change it a bit. Anddataset.getTables()also returns metadataasyncdoesn't work in the browser. I removed it.fs-extrabecause in the web worker it will read the file content from IndexedDB