Open
Conversation
|
这是来自QQ邮箱的假期自动回复邮件。你好，我最近正在休假中，无法亲自回复你的邮件。我将在假期结束后，尽快给你回复。
|
roblarsen
requested changes
Sep 6, 2023
Member
roblarsen
left a comment
roblarsen
left a comment
There was a problem hiding this comment.
If you're still interested, reduce the PR to the questions with ✅ and then we can work one more round on the wording. Thanks!
| * Have you used different HTML templating languages before? | ||
| * What is the difference between `canvas` and `svg`? | ||
| * What are empty elements in HTML ? | ||
| * What are the semantic HTML5 page structure elements? |
Member
There was a problem hiding this comment.
This is trivia. Asking about how people use semantic elements is better than asking them to list them.
| * What is the difference between `canvas` and `svg`? | ||
| * What are empty elements in HTML ? | ||
| * What are the semantic HTML5 page structure elements? | ||
| * What is an API for HTML5? Can you name some APIs in HTML5? |
Member
There was a problem hiding this comment.
If you want to ask about an HTML5 API, you could focus a question around a specific API. This is a trivia question.
| * What are empty elements in HTML ? | ||
| * What are the semantic HTML5 page structure elements? | ||
| * What is an API for HTML5? Can you name some APIs in HTML5? | ||
| * What is an iFrame? What are the risks of using it within your code? |
| * What is an API for HTML5? Can you name some APIs in HTML5? | ||
| * What is an iFrame? What are the risks of using it within your code? | ||
| * What are the media element tags introduced by HTML5? | ||
| * Describe how can a copyright symbol be added to the webpage using HTML5? |
Member
There was a problem hiding this comment.
I would love to see a question about character encoding (if there's not one.) This is a 2 second answer.
| * What are the semantic HTML5 page structure elements? | ||
| * What is an API for HTML5? Can you name some APIs in HTML5? | ||
| * What is an iFrame? What are the risks of using it within your code? | ||
| * What are the media element tags introduced by HTML5? |
Member
There was a problem hiding this comment.
There are good questions about embedding media, not just listing the elements.
| * Can you give an example of a pseudo class? Can you provide an example use case for a pseudo class? | ||
| * What is the difference between a block level element and an inline element. Can you provide examples of each type of element? | ||
| * What is the difference between CSS Grid and Flexbox? When would you use one over the other? No newline at end of file | ||
| * What is the difference between CSS Grid and Flexbox? When would you use one over the other? |
Member
There was a problem hiding this comment.
This is a good discussion question
| * What is the difference between a block level element and an inline element. Can you provide examples of each type of element? | ||
| * What is the difference between CSS Grid and Flexbox? When would you use one over the other? No newline at end of file | ||
| * What is the difference between CSS Grid and Flexbox? When would you use one over the other? | ||
| * What are the Flexbox advantages compared to floats? |
Member
There was a problem hiding this comment.
You could reword this to be something like "Compare flexbox with legacy layout techniques."
| * What is the difference between CSS Grid and Flexbox? When would you use one over the other? No newline at end of file | ||
| * What is the difference between CSS Grid and Flexbox? When would you use one over the other? | ||
| * What are the Flexbox advantages compared to floats? | ||
| * What properties does justify-content and align-items share in CSS Flexbox? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added 5 new questions on the HTML page and 2 new questions on the CSS page. There are no required dependencies for this update,
Fixes # (issue):
None
Type of change:
Please delete options that are not relevant.
Checklist:
Pull requests should be thought of as a conversation. There will be some back and forth when trying to get code merged into this or any other project. With all but the simplest changes you can and should expect that the maintainers of the project will request changes to your code. Please be aware of that and check in after you open your PR in order to get your code merged in cleanly.
Thanks!