Conversation
Pulls lib-jsonnet PR-257 which adds packageManager='pnpm' support to workflowJavascriptPackage. Workflows still emit yarn-based output at this step because .github.jsonnet has not been updated yet.
- Pin packageManager to pnpm@10.33.4 - Bump engines.node to >=24 - Bump version 4.0.13 -> 4.0.14 (publish-preview check-version-bump) - Add .nvmrc (24), .npmrc (@gynzy -> npm.pkg.github.com) - Update lint script + pre-commit hook to use pnpm (corepack blocks yarn calls now that packageManager is pinned) - Drop deprecated husky v9 shebang lines
- .github.jsonnet now invokes workflowJavascriptPackage(packageManager='pnpm', repositories=['github']); regenerated workflows now use node:24, pnpm, and push exclusively to npm.pkg.github.com. - Drop legacy ci/npm.sh + ci/publish.sh (npm.gynzy.net/yarn publish), now superseded by helper-generated publish jobs. Generated YAML verified to contain no references to npm.gynzy.net, setGynzyNpmToken, or yarn.
The files allowlist added to package.json is now the single source of truth for what ships. Removing .npmignore eliminates duplicate config. Tarball impact (pnpm pack): - packed: 459 KB -> 21 KB (-95%) - unpacked: 663 KB -> 76 KB (-88%) - files: 39 -> 28 Net leakage vs. previous .npmignore behavior: ~1.6 KB (addon/.gitkeep, app/.gitkeep, config/ember-try.js).
fhp
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates
@gynzy/ember-sortableto pnpm v10, Node 24, and publishing to GitHub Packages on top ofutil.workflowJavascriptPackage()from lib-jsonnet. Also performs a publish-hygiene pass: package now uses afilesallowlist instead of.npmignore, dropping the published tarball from 459 KB to 21 KB.Migration scope
packageManager: "pnpm@10.33.4").engines.nodeto>=24,.nvmrc->24, CI image ->node:24.@gynzy:registry=https://npm.pkg.github.com). Generated YAML has no references tonpm.gynzy.netorsetGynzyNpmToken.4.0.13->4.0.14(PATCH bump for publish-preview's check-version-bump action).packageManager='pnpm'support toworkflowJavascriptPackage). Repo was already onboarded to lib-jsonnet — no bootstrap needed.ci/npm.sh+ci/publish.sh(yarn publish to npm.gynzy.net), now superseded by helper-generated publish jobs..husky/pre-commithook switched fromyarntopnpm(corepack blocks theyarnbinary oncepackageManageris pinned). Deprecated husky v9 shebang lines removed.Dependency
This PR depends on lib-jsonnet#257. Workflows are currently regenerated from
pr-257. Follow-up after adopted-ember-addons#257 merges to prod: re-runsh .github/jsonnet/pull-upstream-and-rebuild.sh(noPR_NUMBER) to repin to prod and commit the diff.Repo facts (discovery)
mainisPublicFork=true(runner:ubuntu-latest)build=ember build,lint=ember-template-lint . && eslint .,test:ember=ember test,test:all=ember try:each. No plaintestscript.pnpm-publish-previewjob runspnpm run buildby default, matching previous behavior.testJob=nullis deliberate — there was no separate test job before, and adding browser-basedtest:emberto CI is out of scope for this migration.pnpm install --frozen-lockfile,pnpm run lint,pnpm run buildall pass.Generated workflows
Note: the spec template used
repositories=['github', 'gynzy'], but the hard requirement of GitHub-Packages-only publishing forbidssetGynzyNpmTokenin the generated YAML, so the list is['github']only.Publish hygiene
pnpm packbaseline vs after:The biggest single contributor to the previous tarball was
demo.gif(510 KB, a README marketing asset). Other stripped:CHANGELOG.md(36 KB),V2_MIGRATION_RFC.md(33 KB), migration guides,RELEASE.md,CODE_OF_CONDUCT.md,.husky/,.claude/,.github.jsonnet,catalog-info.yaml,Makefile,.gitattributes,.nvmrc.filesarray shipped:(npm/pnpm implicitly include
package.json,README.md,LICENSE.md.).npmignoredecision: deleted entirely (option a). The new tarball includesaddon/.gitkeep,app/.gitkeep, andconfig/ember-try.js— a combined ~1.6 KB of leakage, trivial against the 438 KB reduction. Thefilesarray is the single source of truth for the published surface.CI publish bloat observation (no action required this PR)
The helper-generated publish jobs run
pnpm config set store-dir .pnpm-store && pnpm install --frozen-lockfilebeforepnpm publish. With the previous.npmignore-based approach, the in-workspace pnpm store risked leaking into the tarball in CI. Thefilesallowlist eliminates that risk regardless — supporting motivation for the allowlist migration, not a blocker.Test plan
misc/verify-jsonnet-gh-actionsjob green.pnpm-publish-previewjob builds withnode:24+pnpmand publishes a4.0.14-pr<N>.<run>tarball to GitHub Packages.filesarray (plus auto-included README/LICENSE/package.json) are present.main:pnpm-publishjob publishes4.0.14to GitHub Packages.sh .github/jsonnet/pull-upstream-and-rebuild.sh(withoutPR_NUMBER) and open a small follow-up PR with the diff.Open Questions
pnpm run lintandpnpm run test:emberin CI going forward, that's a separate, scoped change.