Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new “Success 450” color to the iOS Source color palette (per the linked Figma), exposing it via ColorPalette and surfacing it in the sample palette screen.
Changes:
- Added a new
Success450color asset with RGB hex#28A85F. - Exposed the asset as
ColorPalette.success450. - Displayed the new swatch in the sample app’s Success palette section.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| SourceSample/SourceSample/Color/PaletteViewModel.swift | Adds the new success450 swatch to the “Success” section in the sample palette list. |
| Sources/Source/ColorPalette/Palette.xcassets/Success450.colorset/Contents.json | Introduces the Success450 color asset with components matching #28A85F. |
| Sources/Source/ColorPalette/ColorPalette.swift | Adds public static let success450 to expose the new asset via the public palette API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
iUsmanN-Guardian
approved these changes
Apr 7, 2026
Contributor
iUsmanN-Guardian
left a comment
iUsmanN-Guardian
left a comment
There was a problem hiding this comment.
I'm facing some trouble building this project, but that's on my side. I think the code looks fine and should work well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Figma: https://www.figma.com/design/b2qv2OMLoNCYnP01ipfrP7/%E2%97%88-Core-library?node-id=15325-176979&t=3ykPg7SFLEoxSZQN-0
Testing notes/instructions:
Adds Success 450 as #28A85F.
Checklist
Recommended reviewers
Specific notes/instructions for the reviewer:
For pull requests introducing UI changes: