Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dotcom-rendering/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"@guardian/bridget": "8.9.0",
"@guardian/browserslist-config": "6.1.0",
"@guardian/cdk": "62.6.1",
"@guardian/commercial-core": "29.0.0",
"@guardian/commercial-core": "32.0.0",
"@guardian/core-web-vitals": "7.0.0",
"@guardian/eslint-config-typescript": "12.0.0",
"@guardian/identity-auth": "6.0.1",
Expand Down
3 changes: 1 addition & 2 deletions dotcom-rendering/src/components/YoutubeAtom/YoutubeAtom.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import type { Participations } from '@guardian/ab-core';
import type { ConsentState } from '@guardian/libs';
import { useCallback, useState } from 'react';
import type { ArticleFormat } from '../../lib/articleFormat';
Expand Down Expand Up @@ -43,7 +42,7 @@ export type Props = {
format: ArticleFormat;
shouldStick?: boolean;
isMainMedia?: boolean;
abTestParticipations: Participations;
abTestParticipations: Record<string, string>;
kicker?: string;
shouldPauseOutOfView?: boolean;
iconSizeOnDesktop: PlayButtonSize;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { css, Global } from '@emotion/react';
import type { Participations } from '@guardian/ab-core';
import { buildImaAdTagUrl } from '@guardian/commercial-core';
import type { ConsentState } from '@guardian/libs';
import { log } from '@guardian/libs';
Expand Down Expand Up @@ -40,7 +39,7 @@ type Props = {
enableAds: boolean;
adTargeting: AdTargeting;
consentState: ConsentState;
abTestParticipations: Participations;
abTestParticipations: Record<string, string>;
renderingTarget: RenderingTarget;
};

Expand Down Expand Up @@ -369,7 +368,7 @@ const createOnReadyListener =
const createImaAdsRequestCallback = (
adTargeting: AdTargeting | undefined,
consentState: ConsentState,
abTestParticipations: Participations,
abTestParticipations: Record<string, string>,
isSignedIn: boolean,
) => {
const adTargetingEnabled = adTargeting && !adTargeting.disableAds;
Expand All @@ -385,7 +384,7 @@ const createImaAdsRequestCallback = (
adUnit,
customParams,
consentState,
clientSideParticipations: abTestParticipations,
abTestParticipations,
isSignedIn,
});
adsRenderingSettings.useStyledNonLinearAds = true;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { ConsentState } from '@guardian/libs';
import { useEffect, useState } from 'react';
import type { ArticleFormat } from '../lib/articleFormat';
import { useAB } from '../lib/useAB';
import { useBetaAB } from '../lib/useAB';
import { useAdTargeting } from '../lib/useAdTargeting';
import type { AdTargeting } from '../types/commercial';
import type { AspectRatio } from '../types/front';
Expand Down Expand Up @@ -108,8 +108,8 @@ export const YoutubeBlockComponent = ({
const adTargeting = useAdTargeting(duration);
const { renderingTarget } = useConfig();

const abTests = useAB();
const abTestParticipations = abTests?.participations ?? {};
const abTests = useBetaAB();
const abTestParticipations = abTests?.getParticipations() ?? {};

/**
* It's possible to have duplicate video atoms on the same page.
Expand Down
20 changes: 6 additions & 14 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading