Fix date hydration problem for match kickOff#15622
Open
marjisound wants to merge 1 commit intomainfrom
Open
Conversation
The kickOff date was being hydrated as a string, which caused the hydration to fail when the component tried to call .format() with it. This commit adds a fixHydration function that converts the kickOff string back into a Date object before passing it to the FootballMatchHeader component. Co-authored-by: Jamie B <53781962+JamieB-gu@users.noreply.github.com>
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
jamesmockett
approved these changes
Mar 30, 2026
Contributor
jamesmockett
left a comment
jamesmockett
left a comment
There was a problem hiding this comment.
Perhaps we should change the type to a string which would match the fixture / results pages? (Which previously encountered the same issue.)
For now this is a good fix 👍
Member
|
Not for this PR - but perhaps we should throw an exception if there is a JS type that we can't serialise here: |
arelra
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paired with @JamieB-gu
What does this change?
The kickOff date in football match was being hydrated as a string, which caused the hydration to fail when the component tried to call .format() with it. This commit adds a fixHydration function that converts the kickOff string back into a Date object before passing it to the FootballMatchHeader component.