Draft
Conversation
domlander
added
run_chromatic
github-actions
bot
removed
the
run_chromatic
domlander
force-pushed
the
doml/refactor-card-age
branch
from
18f20b5 to
152cfc6
Compare
github-actions
bot
removed
the
run_chromatic
domlander
force-pushed
the
doml/refactor-card-age
branch
from
152cfc6 to
f2dbc7b
Compare
github-actions
bot
removed
the
run_chromatic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Refactor card age. No longer need to pass in
isTagPageto Card component.Why?
To make the code easier to work with. Props should ideally describe the behaviour of the component, not the characteristics of the parent. They scale much better when following this practice.
Cardis used widely and often touched.For example, if I want to call Card from a new component, when considering card age:
showAgeprop, but I would need to add extra logic to the component to choose between displaying time relatively or absolutely. I would maybe need to add another prop if my new component does not fall into the existing buckets of front page or tag page.showAgeandageFormatto choose whether to show the age and the format. No changes to the Card component would be needed.