Use relative paths for dev apps assets to prevent CORS errors#15615
Open
DanielCliftonGuardian wants to merge 1 commit intomainfrom
Open
Use relative paths for dev apps assets to prevent CORS errors#15615DanielCliftonGuardian wants to merge 1 commit intomainfrom
DanielCliftonGuardian wants to merge 1 commit intomainfrom
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Previously, using a hardcoded absolute URL for development assets in apps emulators (http://localhost:3030/) was causing Cross-Origin Resource Sharing (CORS) errors.
By switching to a relative path (/), the browser will request assets from the same origin that served the page, eliminating the CORS errors and making the local development environment more robust.