Skip to content

Add STANDARD_BUTTON and associated fields #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonathonherbert wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add STANDARD_BUTTON and associated fields #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0992614
v34.0.0 published by gnm-notona
gu-scala-library-release[bot] Nov 20, 2025
28f745c
Post-release of v34.0.0 by @gnm-notona: set snapshot version
gu-scala-library-release[bot] Nov 20, 2025
12b9fce
Use release workflow v2
jonathonherbert Dec 1, 2025
e282112
Add STANDARD_BUTTON and associated fields
jonathonherbert Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
jobs:
scala-maven-release:
name: Maven Release
uses: guardian/gha-scala-library-release-workflow/.github/workflows/reusable-release.yml@v1
uses: guardian/gha-scala-library-release-workflow/.github/workflows/reusable-release.yml@v2
permissions: { contents: write, pull-requests: write }
secrets:
SONATYPE_TOKEN: ${{ secrets.AUTOMATED_MAVEN_RELEASE_SONATYPE_TOKEN }}
Expand Down
10 changes: 10 additions & 0 deletions models/src/main/thrift/content/v1.thrift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,12 @@ struct PullquoteElementFields {

enum LinkType {
PRODUCT_BUTTON = 0,
STANDARD_BUTTON = 1
}

enum VisualHierarchyImportance {
PRIMARY = 1
SECONDARY = 2
}

struct LinkElementFields {
Expand All @@ -455,6 +461,10 @@ struct LinkElementFields {
2: optional string url;

3: optional LinkType linkType;

4: optional VisualHierarchyImportance importance;

5: optional bool openTargetInNewWindow;
}

struct TweetElementFields {
Expand Down
5 changes: 2 additions & 3 deletions project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
addSbtPlugin("com.github.sbt" % "sbt-release" % "1.1.0")
addSbtPlugin("ch.epfl.scala" % "sbt-version-policy" % "3.2.0")
addSbtPlugin("org.xerial.sbt" % "sbt-sonatype" % "3.9.10")
addSbtPlugin("com.github.sbt" % "sbt-release" % "1.4.0")
addSbtPlugin("ch.epfl.scala" % "sbt-version-policy" % "3.2.1")
addSbtPlugin("pl.project13.scala" % "sbt-jmh" % "0.3.5")

addSbtPlugin("com.twitter" % "scrooge-sbt-plugin" % "22.1.0")
Expand Down
2 changes: 1 addition & 1 deletion version.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
ThisBuild / version := "33.0.1-SNAPSHOT"
ThisBuild / version := "34.0.1-SNAPSHOT"