Add calloutType field to callout element #273
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gu-scala-library-release bot
added a commit
that referenced
this pull request
Nov 14, 2025
… philmcmahon philmcmahon published release version 34.0.0-PREVIEW.pm-callout-type.2025-11-14T1725.7389da8b using gha-scala-library-release-workflow: https://github.com/guardian/gha-scala-library-release-workflow Release-Version: 34.0.0-PREVIEW.pm-callout-type.2025-11-14T1725.7389da8b Release-Initiated-By: https://github.com/philmcmahon Release-Workflow-Run: https://github.com/guardian/content-api-models/actions/runs/19371708052 Release-Notes: #273
Contributor
|
@philmcmahon has published a preview version of this PR with release workflow run #101, based on commit 7389da8: 34.0.0-PREVIEW.pm-callout-type.2025-11-14T1725.7389da8b Want to make another preview release?Click 'Run workflow' in the GitHub UI, specifying the pm-callout-type branch, or use the GitHub CLI command: gh workflow run release.yml --ref pm-callout-type Want to make a full release after this PR is merged?Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command: gh workflow run release.yml |
twrichards
approved these changes
Jan 6, 2026
twrichards
left a comment
twrichards
left a comment
There was a problem hiding this comment.
LGTM - though ideally we'd get a CAPI dev to give final 👍
Contributor
Author
|
Closing this - we have found a way of implementing reporter callouts without the content API having to store the additional calloutType field |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This pr is part of an effort to replace the quick guide atoms in stories such as this one with a callout made in the targeting tool. The motivation is to prevent callout text from being shared with syndication partners.
To do this, I'm introduce a new type of callout - 'reporter callout' - which differs from the existing 'callout' (which is really a 'community callout') in that it is a lot simpler, with no associated Tag or Form stack form. The rendering will also differ. With that in mind, we need a way to distinguish between the existing 'callout' elements and these new reporter callouts. This PR adds a new 'calloutType' field to the callout fields type.
How to test
Needs testing on CODE