fix: TC-2773 Do not collect indirect dependencies inside dependencyManagement and plugins#177
Merged
soul2zimate merged 2 commits intoguacsec:mainfrom Aug 25, 2025
Merged
Conversation
…nagement and plugins
ruromero
approved these changes
Aug 25, 2025
Collaborator
ruromero
left a comment
ruromero
left a comment
There was a problem hiding this comment.
Changes look good to me. My only concern is that you are adding too many unnecessary comments.
Try to limit them to where the code can be misleading and even in this cases maybe a variable or a specific function can be enough.
Contributor
Author
|
Thanks for the review, I add another commit to remove the unnecessary comment for different conditions and debug variable. |
Collaborator
|
Thanks, LTGM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix: TC-2773 Do not collect indirect dependencies inside dependencyManagement and plugins
Related issue (if any): fixes https://issues.redhat.com/browse/TC-2773
Checklist
Additional information