Python: Expose verify_peer_callback for Custom TLS Certificate Verification#546
Open
aibrahem wants to merge 1 commit intogrpc:masterfrom
Open
Python: Expose verify_peer_callback for Custom TLS Certificate Verification#546aibrahem wants to merge 1 commit intogrpc:masterfrom
aibrahem wants to merge 1 commit intogrpc:masterfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposes adding an optional
verify_peer_callbackparameter togrpc.ssl_channel_credentials()andgrpc.ssl_server_credentials()in Python, backed by the existing C-core
grpc_tls_certificate_verifier_externalAPI.Addresses the long-standing request in
grpc/grpc#32635 (labeled
help wanted).Earlier attempt in grpc/grpc#12656 stalled
on async/interpreter-lock concerns; this proposal starts with
synchronous mode, which the C-core API supports, and leaves async
as a future extension.
A working prototype exists locally with 10 unit tests (passing on
Bazel). I posted the design questions at grpc/grpc#32635 a week ago
but received only non-maintainer feedback, so I'm submitting the
gRFC to start the formal review process. Open to redirecting the
API shape based on reviewer input.