Skip to content

Conversation

@kannanjgithub
Copy link
Contributor

No description provided.

Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sending what I have


## Proposal
This proposal has two parts:
* Setting SNI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not render well. If you click the three dots (...) at the top-right of this file in github and "View field" then you can see how it renders.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "two parts" are still unintelligible. Like, the file structure is unclear.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "two parts" are still unintelligible. Like, the file structure is unclear.

Used numbering and made the text continue after the respective headings.

Copy link
Contributor Author

@kannanjgithub kannanjgithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@kannanjgithub
Copy link
Contributor Author

I have given a language specific heading for caching the Certificate provider. Alternatively I can remove the section altogether also.

Copy link
Member

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all those changes, Kannan! This is looking really good.

I'd still like Eric's input on the question about the breaking behavior change, to make sure we're in agreement about how to handle that. But I think that's the only really substantive issue remaining open.

Please let me know if you have any questions. Thanks!

@ejona86 ejona86 self-requested a review September 3, 2025 16:21
Copy link
Member

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kannanjgithub kannanjgithub merged commit 517c416 into grpc:master Sep 22, 2025
1 check passed
@kannanjgithub kannanjgithub deleted the SNI branch September 22, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants