-
Notifications
You must be signed in to change notification settings - Fork 249
A101: xDS-Based setting SNI and server certificate SAN validation #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…SNI-SAN-validation.md
…nd-SNI-SAN-validation.md
ejona86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sending what I have
|
|
||
| ## Proposal | ||
| This proposal has two parts: | ||
| * Setting SNI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not render well. If you click the three dots (...) at the top-right of this file in github and "View field" then you can see how it renders.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "two parts" are still unintelligible. Like, the file structure is unclear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "two parts" are still unintelligible. Like, the file structure is unclear.
Used numbering and made the text continue after the respective headings.
kannanjgithub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
|
I have given a language specific heading for caching the Certificate provider. Alternatively I can remove the section altogether also. |
markdroth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all those changes, Kannan! This is looking really good.
I'd still like Eric's input on the question about the breaking behavior change, to make sure we're in agreement about how to handle that. But I think that's the only really substantive issue remaining open.
Please let me know if you have any questions. Thanks!
markdroth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
No description provided.