protoc-gen-rust-grpc: Fix well-known protos for prost#2665
Open
ejona86 wants to merge 3 commits into
Open
Conversation
This makes the well-known protos available to the protoc built by protoc-gen-rust-grpc. It needed to "install" the protos, but also run the "installed" protoc executable so that it could find the protos in the include/ directory next to its own bin/. Note that the well-known protos don't yet work with grpc-protobuf-build because of missing crate mapping. With that in place, it can be used in the examples.
ejona86
force-pushed
the
protoc-cmake-prost
branch
from
de97b61 to
62e5b90
Compare
dfawley
approved these changes
May 29, 2026
Comment on lines
+40
to
+41
| `protoc-gen-rust-grpc` crate. When using this approach, you can also set the | ||
| `protoc-gen-rust-grpc` feature to use the same protoc for the prost examples. |
Member
There was a problem hiding this comment.
As discussed offline, I think we should move this new bit up to the previous section since it's about how we can avoid the protoc install for tonic builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the well-known protos available to the protoc built by protoc-gen-rust-grpc. It needed to "install" the protos, but also run the "installed" protoc executable so that it could find the protos in the include/ directory next to its own bin/. Note that the well-known protos don't yet work with grpc-protobuf-build because of missing crate mapping.
With that in place, it can be used in the examples.